Update default_log_colors from log_colors instead of replace it

[espdev]

Update default_log_colors from log_colors instead of replace it

[borntyping]

An alternative that would work in the case of dictConfig would be to add a new parameter, though the code in Formatter.__init__ is already quite messy. It's probably easier to just copy the defaults into the dictConfig, as there aren't very many and they don't change:

logging:
  formatters:
    colored:
      (): "colorlog.ColoredFormatter"
      format: "..."
      log_colors:
        WARNING: "yellow"
        ERROR: "red"
        CRITICAL: "bold_red"

        INFO: "white"
        DEBUG: "light_blue"

[borntyping]

You can do easily this by merging the default_log_colors dictionary into a new one:

formatter = ColoredFormatter(
    ...
    log_colors={
        **colorlog.default_log_colors,
        'DEBUG': 'light_white',
    },
)

This will give you a ColoredFormatter that uses light_white for DEBUG records but still uses the default for other records.

---

Changing how the constructor works here would also mean it'd need a way to unset the defaults and would be a breaking change. For example, this wouldn't work the same way anymore:

formatter = ColoredFormatter(log_colors={'ERROR': 'light_white'})

At the moment that will make ERROR the only coloured records, instead of just changing the color of ERROR and using the default for other levels.

[espdev]

@borntyping thanks for the response

Suggested approach unfortunately will not work with log configs. For logging configuration I use dictConfig from yaml file:

logging:
  formatters:
    colored:
      (): "colorlog.ColoredFormatter"
      format: "..."
      log_colors:
        INFO: "white"
        DEBUG: "light_blue"

In this case I cannot update log_colors from colorlog.default_log_colors in the config.

Changing how the constructor works here would also mean it'd need a way to unset the defaults and would be a breaking change. For example, this wouldn't work the same way anymore:

I agree. Suggested behavior by me is breaking changes. It's not good, so best left as is.