Expired 'VotingResult' in 'VotingBox' must be moved to 'ReservedBox'

[bosnet]

Expired 'VotingResult' in 'VotingBox' must be moved to 'ReservedBox'

[leejames00]

So do you mean checking the VotingBox, WaitingBox, and ReservedBox every 2 minutes? I think it's a good idea since the the VotingResult does not have to expire in "exactly" 2 minutes. A drawback could be a votingResult waiting for 3min59s before expiring to next box

[Charleslee522]

1. save current state(snapshot) and check validity(uniqueness of hash in boxes)
2. after 2 min, compare to previous snapshot and find target to move the other box
3. Repeat above

In the worst case, some ballot may take 4 min to move WaitingBox to ReservedBox. But this is not that big a deal.

[Charleslee522]

If time is recorded, you have to check how long does it take periodically.
I figure, using time.ticker is better.

[leejames00]

Aha I agree. I was thinking about other ways too

[leejames00]

Why are the Message.Hashes sorted in BallotBox? Will it be replaced by a combining function?

sebak/lib/ballot.go

Line 380 in 3cf6918

Hashes sort.StringSlice // `Message.Hash`es

[Charleslee522]

@leejames00 Would you please let me know in detail about combining function?

[leejames00]

I was confused on why the Message.Hashes need to be sorted.
Because in SCP, the transaction sets are merged (by a combining function) into one message(or hash)... so if a combining function is implemented, there would be no need for sorting

[Charleslee522]

Aha, there is no combining function in sebak yet. All transactions are handled as they are.

[leejames00]

and also I was thinking about timeouts to VotingResult -- if the VotingResult should be moved from VotingBox to ReservedBox after 2minutes, I think the message hash should be mapped with time

for example,

type BallotBox struct {
	sebakcommon.SafeLock

	Hashes map[hash]time.Time
}

or if there are other suggestions on implementing timeouts please comment :)

[sconeman]

@leejames00 I don't think I need to record time. After the message is moved to the ReservedBox, we don't have to check the time data in the message.

[leejames00]

@astonshnam but after 2 minutes in VotingBox, it should be moved to ReservedBox. How do you check that the VotingResult is expired?

[sconeman]

@leejames00 However, a time check is only needed within the VotingBox. It is unnecessary to change the structure of the BallotBox because of the process in the VotingBox. I want to think about other ways.

[sconeman]

What do you think about changing BallotBox to interface type?

[sconeman]

Node is also an interface type. As follows..

type Node interface {
	Address() string
	Keypair() *keypair.Full
	SetKeypair(*keypair.Full)
	Alias() string
	SetAlias(string)
	Endpoint() *Endpoint
	Equal(Node) bool
	DeepEqual(Node) bool
	GetValidators() map[string]*Validator
	AddValidators(validators ...*Validator) error
	HasValidators(string) bool
	RemoveValidators(validators ...*Validator) error
	Serialize() ([]byte, error)
}

[sconeman]

no. It does not seem to be a good way. Using the interface does not solve this problem. :(

[Charleslee522]

I figure, we need the independent struct BoxManager or ResultManager
This struct can handle Results and Boxes validation, move hashes each other, etc...
We can discuss about it tomorrow in detail :)

[Charleslee522]

I have an idea. I figure, if ticker is attached every ballot, then it is not that good for performance. So, It is better to check every 2 minute by saving snapshot. @astonshnam @leejames00

[Charleslee522]

@leejames00 You fully understand my word :)

[anarcher]

Maybe I don't understand this issue, Is it(gist) right?
gist: https://gist.github.com/anarcher/b8e895f9793b87c1012f101f1bea6af7

[Charleslee522]

@anarcher @astonshnam
I figure it is better to talk about this issue ASAP. Cause we did duplicated works :)

fyi @spikeekips