Giter Site home page Giter Site logo

Comments (4)

koplo199 avatar koplo199 commented on June 2, 2024 1

@pietrodicaprio I made a dummy commit in #3044 to verify it will also work for other PR, and yes it now appears to be working flawlessly 👍 I guess this issue could be closed.

from bottles.

pietrodicaprio avatar pietrodicaprio commented on June 2, 2024

@koplo199 do I understand correctly that the configuration has been changed after the PR was opened?

In that case a repo admin can skip the requirement
image
but I also notice that the new check does not have the Required label. I'll give a look to that

from bottles.

koplo199 avatar koplo199 commented on June 2, 2024

@pietrodicaprio This behavior began after #3034 was merged.

The new check does have the Required label as shown in the screenshot, this is not the issue. The issue is that there's now two Sonar checks: the right/new one (Sonar / Checker (pull_request_target) in the screenshot), and the broken/old one (Sonar Expected — Waiting for status to be reported in the screenshot). The old one just need to be removed from the checks, this is the only needed change.

from bottles.

pietrodicaprio avatar pietrodicaprio commented on June 2, 2024

Thank you for the explanation @koplo199 , #3044 looks to be fixed now while others, like #3016 , do not show the new workflow, they may need to be rebased to trigger the new checks

from bottles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.