Comments (12)
@steven-tey That is a good point and a valid use case. We do know the tenant
and should add that to requested
attribute along with an indication that it came via idp login. We'll make the changes, cc: @niwsa
from jackson.
@deepakprabhakara can confirm that "@boxyhq/saml-jackson": "^1.11.3"
fixes this issue! Thank you so much 🙏
from jackson.
Thanks @steven-tey, we are sorting it out at #1481 and I'll ping you as soon as it is merged and released.
from jackson.
@steven-tey Fixed in https://github.com/boxyhq/jackson/releases/tag/v1.11.3
from jackson.
@steven-tey Thanks for reporting this issue. We are looking into this and will let you know soon.
from jackson.
For the IdP login, since we depend on the Credentials Provider there is no separate profile being passed in from NextAuth. Instead, you can set the profile
inside the user
object returned from provider.authorize
. This can then be accessed via user
object inside signIn
.
// Fetch user info
const userInfo = await oauthController.userInfo(access_token);
if (!userInfo) {
return null;
}
if (userInfo?.id && userInfo?.email) {
return {
id: userInfo.id,
email: userInfo.email,
name: [userInfo.firstName, userInfo.lastName].filter(Boolean).join(' '),
image: null,
profile: userInfo, // <--- Set profile here
};
}
...
callbacks: {
signIn: async ({ user, account, profile }) => {
const _profile = profile ?? user.profile
...
})
}
...
from jackson.
oh nice, that worked! however, the userInfo
object returns the Profile
object, with requested: null
(when it should be returning requested: { tenant: string }
). Is that intentional as well?
from jackson.
@steven-tey In the case of IdP there is nothing that was requested since the login is initiated from the Identity Provider. This is why we leave the requested
attribute as null
from jackson.
@deepakprabhakara Got it, that makes sense! Does that mean that other than configuring SCIM directory sync, there is no way to make sure that the user gets linked to their respective team if they login directly from their Identity Provider for their first login?
from jackson.
@deepakprabhakara Awesome! LMK when it's ready – happy to test it out! :)
from jackson.
Related Issues (20)
- MongoDB database engine connection count goes up and up HOT 14
- Active state gets saved incorrectly in jackson_store for Directory sync HOT 10
- Dark mode support for Admin Portal HOT 23
- SCIM - enterprise User extension support HOT 3
- Error: VT12001: unsupported: JOIN between derived tables HOT 8
- Jackson NPM library cannot correctly POST to Azure ADFS via next-auth HOT 14
- Incorrect type for `DirectorySyncEvent.data.active` HOT 6
- Critical dependency error in `typeorm` import trace HOT 6
- Update the README.md HOT 3
- Update the README.md HOT 5
- Star the Jackson Repository! 🚀 HOT 18
- Add a CONTRIBUTING.md to the Jackson repo HOT 4
- Break up npm into components to reduce size and dependencies
- Support Custom Postgres Schema HOT 2
- Make Setup Link Expiry Time Configurable HOT 5
- Provide method to close all connections opened by the npm library HOT 1
- Fallback for OIDC Provider configuration in the absence of discovery mechanism
- Surface up SAML errors to ease debugging
- Support login_hint parameter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jackson.