Comments (15)
As mentioned in Discord, it has already been done: https://github.com/quadre-code/quadre
I was able to download and run it and everything seemed to work fine, including live preview. If ficristo is interested in merging some or all of his changes into this repo we might even be able to get it working in time for our first release.
from brackets.
+1 Transitioning to Electron is possible as seen from the electron ports. Let's wait for @ficristo. Help from Quadre will significantly lower our efforts to move to Electron. The thing I am worried about is the number of breaking changes involved as we have seen with our transition efforts with Phoenix, and with the original brackets-electron project. In the meantime, @sprintr is also working on an electron port and we could get his help too :)
- Electron shell did not support custom window decorators. Not sure if this is still an issue. But I would be fine to switch to electron without the brackets custom window chrome and themes.
- The work involved to be feature complete across all platforms with full extension support needs to be identified.
- Node support (node built-in electron vs node in brackets)
- Release engineering for all platform builds and QA passes.
from brackets.
@abose Looks like a lot of RND is needed before we even move forward x_x
from brackets.
custom window decorators
That's the last thing this universe needs, why is everyone trying to savagely violate user accessibility with CSD? FFS...
Edit: Damn Gnome to ****ing ****...
from brackets.
@KaKi87 We are using Tauri instead of Electron. The work has started.
from brackets.
Thanks but that link doesn't work thinking
It was set to private. Should be visible now as made public.
from brackets.
@abose For now is switching to electron a priority or is maintaining brackets shell the main concern?
from brackets.
It looks like quadre maintainers would not be able to support us with the port. We investigated quadre and have the following notes:
- Quadre is based on a version of brackets-electron that looks to be in sync with brackets 2017 version.
- The effort required would be heavy to merge in brackets and quadre at this stage. Quadre has moved to typescript and a simple merge would almost certainly fail. A large-scale feature migration effort would also be required, and I'm not entirely sure that we have sufficient resources/time/reason to re-engineer vscode language server code in brackets that came with the last releases.
- We will most likely not get support from quadre Engg for the migration, which would be problematic as the codebase is largely maintained by ficristo and we cannot fall back to any other community members for help.
- There are a lot of breaking changes in quadre: extension management, node layer, lack of unit tests that is not yet ready for production launch and require more work.
With these I guess its safe to conclude:
- A direct merge of Quadre to brackets would be cost-prohibitive to implement.
- We can merge in parts of quadre like electron build/installer generation scripts and the shell compatibility layer for electron from quadre with existing brackets code. This is much simpler and wont be a huge breaking change.
- We cannot do this in a November release with our resources.
- We can work on an electron port parallel in a separate branch with help from @sprintr who is actively working on a port with existing brackets core and merge in parts from quadre as required during the port.
from brackets.
@rileyhawk1417 Maintaining brackets shell is hard as we need to keep up with chromium(CEF) updates and that used to break our integrations regularly across different platforms. For Eg., we can't create Linux builds now as CEF inside brackets shell is ancient and the latest Linux distros do not ship with the required dependencies that CEF inside brackets shell needs.
Updating CEF regularly is not trivial. Updates usually had brought in focus issues and other platform-specific issues that we have to address separately in the shell.
Similarly, brackets ship with an ancient node binary which we have not dared to update since node 6.0. Electron comes with built-in node support that is kept up to date but the electron team.
Electron is a well-maintained port that does all these things for us for free. It is a safe long-term bet and the brackets devs can concentrate more on developing rich features for brackets than worry about the shell component.
from brackets.
Hey @sprintr, do stuff!!
from brackets.
Will resolve: brackets-archive/bracketsIssues#14256
from brackets.
We have formally reached the conclusion to switch to electron for brackets shell.
Further progress will be tracked in this project: https://github.com/brackets-cont/brackets/projects/3
from brackets.
Hello,
May I suggest using Tauri instead of Electron ? 😅
Thanks
from brackets.
Closing as we have chosen to use Tauri instead of Electron.
Please track progress at https://github.com/orgs/phcode-dev/projects/1
from brackets.
Thanks but that link doesn't work 🤔
from brackets.
Related Issues (20)
- Fix for broken Live Preview after latest chrome update HOT 9
- live preview has an issue with chrome v111 HOT 2
- having problem previewing my codes
- LivePreview not opening in Chrome because there is a "space" in my User Account name on my PC. HOT 5
- Live preview doesnt show with bracket version 2.2.1 using chrome browser with latest chrome version 111.0.5563.111 in windows 10 HOT 1
- Brackets query HOT 1
- On first run, Brackets reports that it is unsupported HOT 1
- Cannot update Brackets HOT 1
- I do not have settings in latest version HOT 4
- Discord: Chat with brackets community HOT 2
- Extension Registry login broken HOT 1
- Live Preview does not work anymore with Chrome on macOS HOT 6
- i can't change language Ru to eng. Please help me HOT 2
- Highlight and Find function does not work normally in 500kb file
- Version Number Mismatch on the macOS Application. HOT 15
- Linux Version HOT 3
- CSS row-gap not recognized.
- feedback HOT 1
- feedback
- Money Transfer | Global Money Transfer | Western Union
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brackets.