Support checking repository on push to branch (not via PR)

[bradleyfalzon]

Support checking repository on push to branch (not via PR)

[bradleyfalzon]

Correct, that's what the go-github PR is for, just working out how to best make https://github.com/bradleyfalzon/gopherci/blob/master/internal/github/handlers.go#L67 a little more generic (move to event method which accepts statuses url, analyser.config and installationID), so a small refactor is needed but I think it's all relatively straight forward.

To begin with, I'll just hit the statuses API and in the near future, we can organise email notifications (and other notifications customisation in general), but the first step is having us check the push request.

[bradleyfalzon]

We'll need to also support sending an email notification to the user on failure, but it's not clear to me exactly how to get the user's permission. I presume only members of the user/organisation can push directly to a branch, and in which case I may or may not have access to their private email address.

Discovering email is related to #3

[fortytw2]

Additionally, gopherCI seems to only build a PR on the first opening of it, not for subsequent commits on the same PR (not sure if I'm misreading this though)

[bradleyfalzon]

Yeah and I'm tracking that in #24 it's a really simple fix so will address soon.

[bradleyfalzon]

This is now being blocked by google/go-github#533 but I don't think I'll have an implementation before that's merged in anyway.

[dmitshur]

Note many people would push to their repository then make a PR, this workflow should ideally not cause GopherCI to run on push and then on PR creation.

Hehe, Travis does that and it's indeed suboptimal. But the fact they haven't resolved it makes me unsure if it's viable to solve it well (maybe it is, maybe it isn't).

Are you planning on using commit statuses to report CI result on pushed commits? I guess so based on google/go-github#533. That's what Travis does too, and I think it'll be great. Just wanted to give the approach a 👍.