Patchwork 2.0

[brain-wp]

Patchwork 2.0

[gmazzap]

@krodyrobi Thanks for the contribution.

Being a major version change, I want to better test any issue before merging on master and release.

If I merge it on dev branch, could you use it from there and please report any issue?

[krodyrobi]

Sure. But could you place it on composer as well, on the dev branch.

[gmazzap]

@krodyrobi Pushed to dev branch.

Of course you can still use Composer, just pull Brain Monkey with "brain/monkey": "dev-dev"

[krodyrobi]

Sorry for the late reply I got off focus with the project.

Unfortunately I'm not able to get Functions::expect() to work.
ReflectionException: Method Mockery\CompositeExpectation::once() does not exist

And for me this is the most important part, ensuring a call was made.
Can't say for sure where the issue is but I've made a small reproducible example.
failing.tar.gz

It doesn't seem to be related to the new php redefinitions, as both a custom and time functions have the same behaviour.

[krodyrobi]

To follow up on that,

The expect call triggers Monkey/MockeryBridge.php __call() with the required data,
on Mockery's side Mockery/CompositeExpectation.php __call() never gets called.

[gmazzap]

@krodyrobi don't really have time now to sort this out, will look at this as sson as I can...

[krodyrobi]

No problem, I'll still look around at least to provide possible insight.

[gmazzap]

Version 2 seems to work fine with Patchwork 2, and with last changes in dev-version/1 seems to work with Patchwork 2 as well.

Will close this after some more tests next days, then release version 1.5 with Patchwork 2 support.

[gmazzap]

Patchwork 2 is now in use for v1 and v2 series, I can close this.