Unit test tidyup

[braindigitalis]

Unit test tidyup

[braindigitalis]

sure feel free to grab it, please do not add any external dependencies such as catch2!

[braindigitalis]

#948 introduced crases and caused unit tests to fail:

coro: offline job                                            FAIL
coro: offline coroutine                                      FAIL
coro: offline task                                           FAIL
coro: offline async                                          FAIL
coro: online event handler                                   PASS
coro: online api calls                                       PASS
coro: online mumbo jumbo in event handler                    SKIPPED

Execution finished in 55.809 seconds.
Failed: 4 Passed: 138 Skipped: 19 Percentage: 97.18%
terminate called after throwing an instance of 'std::system_error'
  what():  Invalid argument
Aborted (core dumped)

As such this breaks CI so we had to roll it back. Anyone welcome to try again but we must make sure that it doesnt break the tests.

The failing tests are skipped when ran as part of a PR (you dont have access to the token) but when it is merged into dev the online tests are ran. This was not tested with a token with the online tests before submitting the PR.

[Jaskowicz1]

This is still open if anyone wants to take this!

[Jaskowicz1]

Gonna take this on myself. I will be basing it off #948 as we agreed that the format was good.

[Jaskowicz1]

I'd put this off for a bit as I faced issues with Mac and whatnot, will look to maybe pick this up over Christmas if no-one else does (as I am busy until then).

[github-actions]

This issue has had no activity and is being marked as stale. If you still wish to continue with this issue please comment to reopen it.

[Jaskowicz1]

Reminder, we're looking for people to complete this project! I'll post this in the Discord too!

[mayankag32]

Hello @Jaskowicz1, I would like to work on this issue, is it still open?

[Jaskowicz1]

Going to actually take this on myself this time.