Fix shadow warnings

[brainsia]

Fix shadow warnings

[hjmjohnson]

@aghayoor Please try to fix these warnings. We don't have a compiler that issues these warnings, so you will have to to it a bit blind.

Hans

[jcfr]

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson [email protected]
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these warnings.
We don't have a compiler that issues these warnings, so you will have to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

[phone]

[Chaircrusher]

We’re standardized on Red Hat Enterprise Linux for all our real servers/workstations. I’ll investigate getting a VM running with ubuntu 13.10… 4.8.1 isn’t quite bleeding edge. I’d maybe wait on 4.9 except for experimenting:
http://www.phoronix.com/scan.php?page=news_item&px=MTc1MDQ

From: Jean-Christophe Fillion-Robin <[email protected]mailto:[email protected]>
Reply-To: BRAINSia/BRAINSTools <[email protected]mailto:[email protected]>
Date: Friday, August 1, 2014 at 11:46 AM
To: BRAINSia/BRAINSTools <[email protected]mailto:[email protected]>
Subject: Re: [BRAINSTools] Fix shadow warnings (#132)

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson <[email protected]mailto:[email protected]>
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these warnings.
We don't have a compiler that issues these warnings, so you will have to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

[phone]

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/132#issuecomment-50907262.

---

Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.

---

[hjmjohnson]

These will only show up in 4.8 gcc. They turned this wanting back off I. 4.9 I think. ITK had similar issues.

Sent from my iPhone

On Aug 1, 2014, at 11:46 AM, Jean-Christophe Fillion-Robin [email protected] wrote:

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version 
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1 

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson [email protected]
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these warnings.
We don't have a compiler that issues these warnings, so you will have to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

[phone]
—
Reply to this email directly or view it on GitHub.

[jcfr]

I think you are talking about "Wunused-local-*typedefs" * flag. And
they all have been fixed in ITK/Slicer .. this allows to keep you code
readable.

Regarding the shadow, the warning in 4.8 are most useful .. if I understand
well they now report what could a real issue:

From https://gcc.gnu.org/gcc-4.8/changes.html:

• The option -Wshadow no longer warns if a declaration shadows a
  function declaration, unless the former declares a function or pointer to
  function, because this is a common and valid case in real-world code
  https://lkml.org/lkml/2006/11/28/239.

On Fri, Aug 1, 2014 at 3:10 PM, hjmjohnson [email protected] wrote:

These will only show up in 4.8 gcc. They turned this wanting back off I.
4.9 I think. ITK had similar issues.

Sent from my iPhone

On Aug 1, 2014, at 11:46 AM, Jean-Christophe Fillion-Robin <
[email protected]> wrote:

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson [email protected]
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these
warnings.
We don't have a compiler that issues these warnings, so you will have
to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
<
https://github.com/BRAINSia/BRAINSTools/issues/132#issuecomment-50904829>
.

[phone]
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

[phone]

[hjmjohnson]

Kent Please take care of this issue when you return on Thursday.

Hans

[Chaircrusher]

Fixed in f00678a

[jcfr]

@Chaircrusher Thanks for working on this.

There are few more:

In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:196:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:559,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:63,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx: In instantiation of ‘typename OutputImageType::Pointer GenericTransformImage(const InputImageType*, const itk::ImageBase<TImage:: ImageDimension>*, itk::Transform<double, 3u, 3u>::Pointer, typename InputImageType::PixelType, const string&, bool) [with InputImageType = itk::Image<float, 3u>; OutputImageType = itk::Image<float, 3u>; DisplacementImageType = itk::Image<itk::Vector<float, 3u>, 3u>; typename OutputImageType::Pointer = itk::SmartPointer<itk::Image<float, 3u> >; itk::Transform<double, 3u, 3u>::Pointer = itk::SmartPointer<itk::Transform<double, 3u, 3u> >; typename InputImageType::PixelType = float; std::string = std::basic_string<char>]’:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.hxx:1386:84:   required from ‘void itk::BRAINSFitHelperTemplate<FixedImageType, MovingImageType>::Update() [with FixedImageType = itk::Image<float, 3u>; MovingImageType = itk::Image<float, 3u>]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:446:20:   required from ‘void itk::BRAINSFitHelper::RunRegistration() [with TLocalCostMetric = itk::MattesMutualInformationImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double, itk::DefaultImageToImageMetricTraitsv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double> >]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:322:43:   required from here
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx:343:54: warning: declaration of ‘VersorRigid3DTransformType’ shadows a global declaration [-Wshadow]
       typedef itk::VersorRigid3DTransform<double>    VersorRigid3DTransformType;
                                                      ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:20:0:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitUtils.h:47:58: warning: shadowed declaration is here [-Wshadow]
 typedef itk::VersorRigid3DTransform<double>              VersorRigid3DTransformType;
                                                          ^
[  9%] Built target CreateDICOMSeries
[  9%] Built target CLIROITestLib
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:196:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:559,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:63,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx: In instantiation of ‘typename OutputImageType::Pointer GenericTransformImage(const InputImageType*, const itk::ImageBase<TImage:: ImageDimension>*, itk::Transform<double, 3u, 3u>::Pointer, typename InputImageType::PixelType, const string&, bool) [with InputImageType = itk::Image<unsigned char, 3u>; OutputImageType = itk::Image<unsigned char, 3u>; DisplacementImageType = itk::Image<itk::Vector<float, 3u>, 3u>; typename OutputImageType::Pointer = itk::SmartPointer<itk::Image<unsigned char, 3u> >; itk::Transform<double, 3u, 3u>::Pointer = itk::SmartPointer<itk::Transform<double, 3u, 3u> >; typename InputImageType::PixelType = unsigned char; std::string = std::basic_string<char>]’:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.hxx:1406:88:   required from ‘void itk::BRAINSFitHelperTemplate<FixedImageType, MovingImageType>::Update() [with FixedImageType = itk::Image<float, 3u>; MovingImageType = itk::Image<float, 3u>]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:446:20:   required from ‘void itk::BRAINSFitHelper::RunRegistration() [with TLocalCostMetric = itk::MattesMutualInformationImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double, itk::DefaultImageToImageMetricTraitsv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double> >]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:322:43:   required from here
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx:343:54: warning: declaration of ‘VersorRigid3DTransformType’ shadows a global declaration [-Wshadow]
       typedef itk::VersorRigid3DTransform<double>    VersorRigid3DTransformType;
                                                      ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:20:0:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitUtils.h:47:58: warning: shadowed declaration is here [-Wshadow]
 typedef itk::VersorRigid3DTransform<double>              VersorRigid3DTransformType;