BRAINS without V3 compatibility

[brainsia]

BRAINS without V3 compatibility

[Chaircrusher]

I responded to a request to take out ITKv3 compatibility last week or the week before. Is Bradley using a current version of BRAINSTools? I'll take a look tomorrow.

---

From: hjmjohnson [[email protected]]
Sent: Wednesday, September 24, 2014 9:40 AM
To: BRAINSia/BRAINSTools
Cc: Williams, Norman K
Subject: [BRAINSTools] BRAINS without V3 compatibility (#152)

-----Original Message-----
From: , Hans Johnson [email protected]:[email protected]
Date: Wednesday, September 24, 2014 at 9:39 AM
To: Bradley Lowekamp [email protected]:[email protected]
Cc: Kent Williams [email protected]:[email protected]
Subject: Re: BRAINS without V3 compatibility

Kent,

Please take care of this ASAP this week.

Hans

-----Original Message-----
From: Bradley Lowekamp [email protected]:[email protected]
Date: Wednesday, September 24, 2014 at 9:37 AM
To: Hans Johnson [email protected]:[email protected]
Cc: Kent Williams [email protected]:[email protected]
Subject: BRAINS without V3 compatibility

Hans,

I am only getting one compilation error when compiling BRAINS is Slicer3d
with out V3 compatibility and 64-bit IDS.

I am getting a funny error here:
https://github.com/BRAINSia/BRAINSTools/blob/master/BRAINSStripRotation/BRA
INSStripRotation.cxx#L31

because there is no New method available, for the Ridgid3DTransform
without V3 Compatibility:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/T
ransform/include/itkRigid3DTransform.h#L68-L71

I am not sure if other issues related to this transform in BRANSTOOLS and
the v3 compatibility.

Thanks,
Brad

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/152.

---

Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.

---

[Chaircrusher]

The problem is that without being pure virtual, Rigid3DTransform and Rigid2D Transform are never supposed to be instantiated. My solution is to replace Rigid3DTransform with VersorTransform, and Rigid2DTransform with CenteredRigid2DTransform.

Those two new transform types should work in this context. If you think different let me know.

[hjmjohnson]

Seems like a good solution.

Hans

From: Kent Williams [email protected]
Reply-To: BRAINSia/BRAINSTools
<[email protected]
ub.com>
Date: Thursday, September 25, 2014 at 8:42 AM
To: BRAINSia/BRAINSTools [email protected]
Cc: Hans Johnson [email protected]
Subject: Re: [BRAINSTools] BRAINS without V3 compatibility (#152)

The problem is that without being pure virtual, Rigid3DTransform and Rigid2D
Transform are never supposed to be instantiated. My solution is to replace
Rigid3DTransform with VersorTransform, and Rigid2DTransform with
CenteredRigid2DTransform.

Those two new transform types should work in this context. If you think
different let me know.

‹
Reply to this email directly or view it on GitHub
#152 (comment) .
{"@context":"http://schema.org","@type":"EmailMessage","description":"View
this Issue on
GitHub","action":{"@type":"ViewAction","url":"https://github.com/BRAINSia/BR
AINSTools/issues/152#issuecomment-56819831","name":"View Issue"}}

[Chaircrusher]

Fixed in 8db648a31e095cc2a4d291c23313938ce70c92ec