Build Error on windows machines

[braintree]

Build Error on windows machines

[lilaconlee]

Thank you for reporting this! We'll take a look at these build issues as we get out of beta and have more time to make sure the project is easy to work on for external devs.

If you're not looking to contribute to braintree-web-drop-in, you can include the already built file in your project with a script tag like this:

  <script src="https://js.braintreegateway.com/web/dropin/1.0.0-beta.4/js/dropin.min.js"></script>

Drop-in will also be available to include via npm in the near future.

[crookedneighbor]

I was able to reproduce the build error on a windows machine. For me, it errors when trying to symlink.

Looks like this is the offending line:

braintree-web-drop-in/gulpfile.js

Line 107 in b91c5d8

fs.symlink(VERSION, 'dist/web/dropin/dev', done);

Strange that the fs module is doing something that windows doesn't like.

[EvanHahn]

It looks like Node has some issues with symlinking on Windows.

[juongithub]

Actually the error you are reporting means that, on Windows, npm cannot find bash (that is a Linux command). I suggest to edit gulpfile.js and to change the line:

spawn('bash', ['-c', args.join(' ')], { [...]

with lines:

var command = 'bash', opt = '-c';
  if (process.platform.indexOf('win')>=0) {
      command = 'cmd';
      opt = '/c';
  }
  spawn(command, [opt, args.join(' ')], { [...]

[crookedneighbor]

@juongithub Do you want to open a PR?

[juongithub]

Yes, I'm opening a PR

[juongithub]

Ok, I'm not able to open a PR... any advice?

[crookedneighbor]

What do you mean that you aren't able to open a PR?

[juongithub]

I'm not familiar to github, I'm not able to commit the new file.

[crookedneighbor]

Here is the Github help article for creating a pull request: https://help.github.com/articles/creating-a-pull-request/

[crookedneighbor]

You will first need to fork the repo so you have your own copy of the repo on Github. https://help.github.com/articles/fork-a-repo/

[crookedneighbor]

I will try out your change later today or tomorrow, but if you'd like to still open a PR before I get to it, feel free.

[juongithub]

Just created a PR, thanks :)

[crookedneighbor]

The symlink error I posted earlier was because you need to run the command prompt as an administrator when on windows. I'll update the docs to indicate this.