Braintree 2.51.0 does not support .NetPlatform v5.4

[braintree]

Braintree 2.51.0 does not support .NetPlatform v5.4

[senwen]

@raymondberg,
Passed tests for our use cases on Windows, Mac and Linux.
Thanks!

[otabekgb]

Please, add .Net Core support.

[dwdickens]

+1 to resolve this. .Net Core is fantastic and the lack of compatability is making me look at Stripe's rest interface instead. It doesn't look like there's much to convert to move Braintree dotnet across - this is a good starting point: https://visualstudiogallery.msdn.microsoft.com/1177943e-cfb7-4822-a8a6-e56c7905292b

[thoughtentity]

Adding another vote for this, especially now that .NET Core 1.0 RTM'd in late June 2016. This is actually a blocker for us deploying on Windows Nano Server since ONLY the .NET Core CLR is supported on that platform. Targeting the .NET Braintree library on a .NET Standard would also future proof the library and allow it to run on an expanded set of platforms including OSX, Linux and mobile platforms such as iOS and Android through Xamarin.

[raymondberg]

Hi, @mkarlsson. We've been able to produce similar results and will be working to resolve this issue. We'll let you know if we have any status/questions for you.

[raymondberg]

@mkarlsson @thoughtentity @otabekgb @dwdickens @gregbty @senwen @abhurtun

We've released 3.0.0 which deprecates support for older platforms and targets support for .NET Core. We'd love feedback on it and for some early integrations to test our solution.

I'm going to close this issue as 3.0.0 addresses this support, but please open other issues or PRs if you discover any improvements we can make. We really appreciate your voices on this!

[senwen]

@raymondberg
I just tried pulling latest from nuget and doing a restore and got this error:

Package Braintree 3.0.0 is not compatible with netcoreapp1.0 (.NETCoreApp,Version=v1.0). Package Braintree 3.0.0 supports: net (.NETFramework,Version=v0.0)
One or more packages are incompatible with .NETCoreApp,Version=v1.0.

Anyone else running this issue?

[raymondberg]

Thanks for reporting it, Senwen!

[thoughtentity]

Quick thing I noticed in the project.json file is that the Braintree library is targeting netcoreapp10 the actual TFM should be netcoreapp1.0 which is likely the cause for the error.

Though the bigger issue is that the Braintree library is using the netcoreapp TFM in the first place which is meant for full applications not libraries. Libraries like Braintree are supposed to target a .Net Standard version based on the required BCL APIs it needs. The TFM for .Net Standard isnetstandard so a TFM targeting .Net Standard 1.2 would like this netstandard1.2. The .Net Standard platform has a much smaller dependency chain then .Net Core App platform.

[senwen]

Also, for dotnet core, the dependency Microsoft.AspNet.WebUtilities should be Microsoft.AspNetCore.WebUtilities 1.0.0 .

[raymondberg]

Thanks again, @thoughtentity and @senwen, for your follow-up. We were able to release 3.0.1 using a different publishing mechanism to ensure both versions of the dll are exposed. Our tests show a fully compatible nuget package on our side; please let us know if you see the same!