Giter Site home page Giter Site logo

DRK Unmend about kirborotations HOT 2 OPEN

LTS-FFXIV avatar LTS-FFXIV commented on July 27, 2024
DRK Unmend

from kirborotations.

Comments (2)

BrakusTapus avatar BrakusTapus commented on July 27, 2024

Cheers, for the feedback, the DRK rotation used in v1.0.0.21 was an older version of Archi's Default Rotation, which should've been exlcuded from the compiler but i mustve forgor,
anyway in newer version of KirboRotation (current v1.0.0.23) a newer version of the DRK rotation should be available.

from kirborotations.

LTS-FFXIV avatar LTS-FFXIV commented on July 27, 2024

Line still in on new version, preventing unmend use

https://github.com/BrakusTapus/KirboRotations/blob/e67160d5ecadfbe7332cf9f7aceabd580cfec9d5/KirboRotations/PvE/Tank/DRK_Default.cs#L289C1-L289C114

line should just be
if (Unmend.CanUse(out act))

bloodweapon should have its own logic for use as basically a pseudo lucid dreaming and when Darkside is up due to darkside halting MP regeneration, XIVsloth has logic showing how it should be used

https://github.com/Nik-Potokar/XIVSlothCombo/blob/47b8f80df7765c729639ded303031e108d2b9476/XIVSlothCombo/Combos/PvE/DRK.cs#L111

and

https://github.com/Nik-Potokar/XIVSlothCombo/blob/47b8f80df7765c729639ded303031e108d2b9476/XIVSlothCombo/Combos/PvE/DRK.cs#L167C4-L167C4

from kirborotations.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.