Giter Site home page Giter Site logo

Comments (2)

kjozwiak avatar kjozwiak commented on June 18, 2024

Labelling as QA/Yes as there's technically a STR/Case outlined via brave/brave-core#22858 (comment). Looks like we're also pushing out the above via Griffin as per brave/brave-variations#982.

from brave-browser.

stephendonner avatar stephendonner commented on June 18, 2024

Verification IN-PROGRESS using

Brave | 1.66.86 Chromium: 124.0.6367.60 (Official Build) beta (x86_64)
-- | --
Revision | f454ab878a85c5d1395e830089a2cb0a1ce77c4e
OS | macOS Version 11.7.10 (Build 20G1427)

1st Run - no Griffin - PASSED

Steps:

  1. installed 1.66.86
  2. launched Brave
  3. confirmed no Griffin-variations study yet in brave://version
  4. opened brave://flags
  5. set brave://flags/#brave-adblock-experimental-list-default to Enabled
  6. restarted Brave
  7. loaded brave://settings/shields/filters

Confirmed Brave Experimental Adblock Rules was checked in Filter Lists

example example example
Screen Shot 2024-04-22 at 12 16 49 PM Screen Shot 2024-04-22 at 12 19 46 PM Screen Shot 2024-04-22 at 12 20 37 PM

2nd Run (w/Griffin-variations seed pulled) - PASSED

Steps:

  1. installed 1.66.86
  2. launched Brave using --variations-server-url=https://variations.bravesoftware.com/seed
  3. loaded brave://version/
  4. confirmed no Griffin-enabling studies
  5. loaded brave://adblock
  6. confirmed Brave Experimental Adblock Rules was NOT checked
  7. relaunched Brave, keeping commandline intact
  8. loaded brave://version
  9. confirmed BraveAdblockExperimentalListDefaultStudy:Enabled
  10. loaded brave://adblock

Confirmed Brave Experimental Adblock Rules was enabled

example example example example
Screen Shot 2024-04-22 at 1 37 48 PM Screen Shot 2024-04-22 at 1 26 03 PM Screen Shot 2024-04-22 at 1 48 56 PM Screen Shot 2024-04-22 at 1 41 32 PM

2nd Run, restart (w/o Griffin-variations seed pulled; set to no-thanks.invalid) - PASSED

Steps:

  1. installed 1.66.86
  2. launched Brave using --variations-server-url=https://no-thanks.invalid
  3. opened brave://version
  4. confirmed NO Brave Experimental Adblock Rules study enrollment
  5. opened brave://adblock
  6. confirmed NO Brave Experimental Adblock Rules checkmark in Filter Lists
  7. restarted, keeping commandline args intact
  8. opened brave://version
  9. confirmed NO Brave Experimental Adblock Rules study enrollment
  10. opened brave://adblock

Confirmed NO Brave Experimental Adblock Rules checkmark

example example example example
Screen Shot 2024-04-22 at 1 56 49 PM Screen Shot 2024-04-22 at 1 58 22 PM Screen Shot 2024-04-22 at 1 59 43 PM Screen Shot 2024-04-22 at 1 59 38 PM

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.