Comments (10)
Clicking edit pendil should show query to edit instead of whole search engine url
from brave-browser.
Note: Although @tathastu871's Brave Android's screenshot (under Actual Result) does show the issue I'm facing (missing Share | Copy | Edit Link
icons when the URL bar is tapped, I think @tathastu871 might be talking about something else.
As such, I've moved the missing Share | Copy | Edit
icons bug/ problem to a new separate Issue at #38507.
from brave-browser.
ALL CHROME AND CHROMIUM BASED BROWSERS ON ANDROID HAS ALDREADY IMPLEMENTED THIS FEATUTE EXCEPT THIRD CLASS BRAVE BROWSER
I'm experiencing the same issue. That being said, previous versions of Brave Android did have the said function -- ie. tapping the URL address bar will show the Share | Copy | Edit Link
icons.
The above function suddenly disappeared from Brave Android v1.66.110, even though I did not make any changes to the browser or system settings on my device.
Observed Behaviour in Brave Android v1.66.110:
Trying to Copy URL:
- Tap URL bar showing hyperlink.
- Whole URL gets highlighted.
- Empty translucent space is displayed below URL bar -- ie. the
Share | Copy | Edit Link
icons are missing. - Tap empty translucent space to remove it, or else webpage below is not accessible.
Trying to Paste URL/Text String:
- Copy URL/text from Brave Android -- using alternative method as workaround (eg. long-press URL to trigger Copy-Paste context menu) -- or from another app.
- Tap Brave Android's URL bar.
- Whole URL (if any) gets highlighted.
- Empty translucent space appears below URL bar -- ie.
Link/Text you copied
text row below URL bar is missing.
Expected/ Normal Behaviour:
To Copy URL:
- Tap URL bar showing hyperlink.
- Whole URL gets highlighted.
- To copy URL, tap
Copy
icon (2 overlapping rectangles) below URL bar. URL copied
floating message is briefly shown at bottom of browser window.
To Paste Copied URL/Text String in Current/New Tab:
- Tap URL bar.
- Tap
Link/Text you copied
text row that appears below URL bar. - Browser instantly loads the pasted URL, or the search results for the pasted text string.
Screenshots of Expected/ Normal Behaviour (collated from various sources):
- Brave Version: v1.66.110 x64 (16 May 2024 stable release, Google Play Store)
- Chromium Version: v125.0.6422.60
- Extensions Installed: Nil
- Problem seen with Brave Shields Disabled: Yes
- Problem seen with Brave Rewards Disabled: Yes
- Other Browsers Installed: Nil
- Device Type: Mobile Phone
- Android Version: v12
from brave-browser.
I think the big issue we have is that the URL bar is not cleared when omnibox is focused
For example, in Chrome I can search Mercedes
and pick a result. When refocusing the omnibox, it clears the box and then shows the current URL as a history entry directly below it (with a copy button).
Clicking the pencil opens what our UI does - editing the URL in the omnibox
from brave-browser.
@bsclifton: I think the big issue we have is that the URL bar is not cleared when omnibox is focused
For example, in Chrome I can search Mercedes and pick a result. When refocusing the omnibox, it clears the box and then shows the current URL as a history entry directly below it (with a copy button).
Isn't the above the usual behaviour both in Chrome/Chromium & Brave ? Tapping to focus the URL bar did/does select whatever is CURRENTLY shown in the URL bar.
When tapped, the focussed URL bar with current text did/does not get cleared.
@tathastu871: Clicking edit pendil should show query to edit instead of whole search engine url
From what I recall from using previous Brave Android versions, the row of Share | Copy | Edit Link
icons (including the pencil Edit
icon) on the right side below the URL bar has always pertained to what is shown within the URL bar itself -- not whatever history URL is on the icons' immediate left side.
If user is still on the search results webpage (as depicted by the search engine or magnifier favicon on extreme left of URL bar), tapping the URL bar did/does select the search engine results URL itself -- be it for copying, editing or sharing.
Only If user then taps on & loads -- for instance -- the Wikipedia result for XYZ in the search result, then tapping on the URL bar would select the Wikipedia URL for XYZ.
Maybe the close placement of the Share | Copy | Edit Link
icons row with the related results/ history row gives rise to misunderstanding amongst some users that these 2 might be related under certain circumstances ...
Personally, since I don't store search history results below the URL bar, I have never misunderstood the actual function & behaviour of the row of Share | Copy | Edit Link
icons under the URL bar.
from brave-browser.
Clicking edit pencil should show query to edit instead of whole search engine urlI am
When we perform a search query on omnibox address bar shows whole searxh engine urls
i search wikipedia on omnibox it takes me to google search query for wikipedia
now i want to change query to wiki if i click on google search bar it very slow and untesponsive and **** brave always crashes.
so when we click edit icom omnibox shows long **** gooogle string ,
instead in other browsers like kiwi it shoes seqrxh query itself not searxh enhine url
so ease of edit the query
from brave-browser.
User here on Community notes that the issue does not occur on Android 9:
https://community.brave.com/t/option-to-copy-link-from-address-bar/549704/4?u=mattches
from brave-browser.
@Brave-Matt: User here on Community notes that the issue does not occur on Android 9:
https://community.brave.com/t/option-to-copy-link-from-address-bar/549704/4?u=mattches
For clarity, user isTroopyciuu at Brave Community forum is describing the same problem (missing Share | Copy | Edit Link
icons upon tapping URL bar) that I am encountering. As mentioned earlier, I had separately posted this as a new issue:
As such, solving the above bug is unlikely to address what user @tathastu871 appears to talking about:
-
Unhappiness that the functionality/ workflow of Brave Android's
Share | Copy | Edit Link
icons is not identical to Kiwi Browser & Google Chrome Android browser. -
Apparent lag & crash when tapping Google search engine's omnibox in their current copy of Brave Android.
from brave-browser.
@tathastu871: now i want to change query to wiki if i click on google search bar it very slow and unresponsive and **** brave always crashes.
Interesting ... tapping on Google Search's omnibox/ search bar should NOT cause Brave to lag or crash. As far as possible, I have repeated your mentioned steps on my Brave Android (current v1.66.113 Stable), & I have not faced any problems.
Since you can always reproduce the crash, you might wish to submit a screen recording of your Brave Android, Crash ID(s) (from: brave://crashes
), & a report for Brave developers to investigate ?
When your Brave Android lagged/ crashed:
- How tabs/ windows are open ?
- Is your autofill service enabled & what is it set to ?
(Your screen recording only shows your preferred workflow for Google Search result's omnibox contents in your Google Chrome Android browser.)
In the Brave Community forum, there are mentions of Brave crashing, when user tries to search using the default/ Google/ any search engine's "search bar". They all seem to be related to user setting the autofill to anything except Google's.
- Brave Android v1.64.113 (01 Apr 2024): https://community.brave.com/t/brave-crashes-when-i-click-on-search-bar/540739
Same issue dating to 2023:
- https://community.brave.com/t/brave-crash-after-when-trying-new-google-search/462608/15
- https://community.brave.com/t/brave-crashes-when-search-bar-is-clicked-round-two/484607/14
- https://community.brave.com/t/brave-crashes-when-search-bar-is-clicked/463700/16
- https://community.brave.com/t/brave-keeps-crashing-when-tapping-on-search-bar-from-any-search-engine/503320
from brave-browser.
@tathastu871: Clicking edit pencil should show query to edit instead of whole search engine url
Personally, I very much prefer Brave Android's current workflow/ functionality of the Share | Copy | Edit Link
icons to quickly manipulate the existing URL/text inside URL bar.
Out of curiosity, I searched past requests in various Brave forums about the above, & the current functionality/ workflow is what various users previously requested.
It seems that you might be requesting to totally change the workflow to instead manipulate the Search Term query inside Google Search engine's omnibox -- as shown in your screen recording of Google Chrome Android.
I don't know if it is practical for Brave developers to create a new config/ flag setting just to allow users like you to choose to make Brave Android behave identically to Google Chrome/ Kiwi Browser in this aspect.
Below is what happens when I try editing the Search Term Query itself -- eg. from wikipedia
to wiki
-- using 2 methods, both of which are super easy.
Method A:
- Tap on search engine's omnibox containing search query
wikipedia
. wikipedia
appears as a text row (prefixed with←
blue arrow) below URL bar.- To return to the original
wikipedia
search results listing instead, tap←
blue arrow.
- To return to the original
- Tap keypad's
Backspace
to edit/ change search query term towiki
.- OR: Tap on
wiki
related-term suggestion, which is likely to appear in listing below URL bar.
- OR: Tap on
- Tap keypad's
Magifier
key to start searching forwiki
.
Not sure if you can reproduce this method, since you mentioned lagging/ crashing when you tap Google Search's omnibox.
Method B:
- Tap URL bar.
- Whole search engine results URL gets highlighted.
- Tap
X
in URL bar, or tap keypad'sBackspace
to delete URL bar's contents. - Use keypad to type in
wiki
. - Tap keypad's
Magifier
key to start searchingwiki
None of the above 2 methods causes unresponsiveness or crash in my Brave Android.
Tested in Brave Android v1.66.113 Stable with:
- Single tab open
- Multiple tabs (3 nos.) open & loaded
- Brave Shields enabled
- Autofill service disabled (never enabled, & don't intend to enable this)
from brave-browser.
Related Issues (20)
- Add iOS News MAU/DAU metrics
- [Follow up to #37348] When device language/region is set to the allowlisted country (ex. USA) it is possible to enable `Rewards` for `Russia` and `Ukraine` HOT 1
- Update wallet portfolio chart to remove allow-same-origin sandbox attribute
- [Android] Parallel downloading setting
- [ads] Favicon found report to rewards if when `shouldNotifyAdsServiceTabContentDidChange` is false
- Action Extension not triggering for txt file
- Enable Bitcoin by default on iOS
- The secure status icon for unknown SSL status is wrong on iOS
- Long title text of a Bookmark in the Bookmarks list is missing and/or faded out
- Search engine favicon should be updated when a different search engine is selected via customize dashboard HOT 1
- Disabling `Close window when closing last tab` breaks `Bring all tabs to this window` functionality.
- [CR 126] change `Switch to this tab` text/border colour - follow up of #38731 HOT 2
- Enable `Reading List` sub menu
- [ZCash] Switch to another zcash endpoint HOT 3
- (Feature) Single-window mode
- Address bar appearance bug
- Brave News inline ads with the same placement id are shown in new tabs
- Leo - Add system standard context menu for query entry field
- Test failure: TransactionConfirmationStoreTests.testPrepareBTCSend()
- [iOS] - Support Multi-Device Skus Payments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave-browser.