Giter Site home page Giter Site logo

Comments (3)

btlechowski avatar btlechowski commented on July 19, 2024

Verified with

Brave 1.68.32 Chromium: 125.0.6422.60 (Official Build) nightly (64-bit)
Revision 07cffa57cd15d0fd66e102fdc5c906d5e49c9fc1
OS Linux

Verified test plan from the description

Verified tab is restored

[16745:16745:0521/185008.222269:VERBOSE2:tab_manager.cc(233)] Restored focused tab with id 57455858

Verified switching tabs works

[16745:16745:0521/185208.475052:VERBOSE2:tab_manager.cc(249)] Tab id 57455858 did become occluded
[16745:16745:0521/185208.517968:VERBOSE2:tab_manager.cc(249)] Tab id 57455860 did become focused

from brave-browser.

kjozwiak avatar kjozwiak commented on July 19, 2024

The above requires 1.66.113 or higher for 1.66.x verification 👍 Removing QA Pass as we'll need to recheck using 1.66.x. However, used #38420 (comment) as the needed verification for both 1.67.x & 1.66.x uplifts as per brave/brave-core#23736 (review) & brave/brave-core#23737 (review).

from brave-browser.

btlechowski avatar btlechowski commented on July 19, 2024

Verified with

Brave 1.66.113 Chromium: 125.0.6422.76 (Official Build) (64-bit)
Revision b1864a9a0152d4f1631121c6b13a7426f50cf336
OS Linux

Verified test plan from the description

Verified tab is restored

[5253:5253:0522/143752.948339:VERBOSE2:tab_manager.cc(243)] Restored focused tab with id 1888054382

Verified switching tabs works

[5253:5253:0522/143853.154349:VERBOSE2:tab_manager.cc(259)] Tab id 1888054384 did become occluded
[5253:5253:0522/143853.158069:VERBOSE2:tab_manager.cc(259)] Tab id 1888054382 did become focused


Verified with

Brave 1.67.91 Chromium: 125.0.6422.76 (Official Build) beta (64-bit)
Revision 14f0efcb744b293ececd4a8c74ec947d8b22e002
OS Linux

Verified test plan from the description

Verified tab is restored

[6726:6726:0522/144335.509087:VERBOSE2:tab_manager.cc(243)] Restored focused tab with id 759141354

Verified switching tabs works

[6726:6726:0522/144615.503198:VERBOSE2:tab_manager.cc(259)] Tab id 759141356 did become occluded
[6726:6726:0522/144615.531876:VERBOSE2:tab_manager.cc(259)] Tab id 759141354 did become focused

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.