Giter Site home page Giter Site logo

Show an interstitial page with an image representation of the actual WebContents for Dummy contents of Shared Pinned tab about brave-browser HOT 2 CLOSED

sangwoo108 avatar sangwoo108 commented on June 23, 2024
Show an interstitial page with an image representation of the actual WebContents for Dummy contents of Shared Pinned tab

from brave-browser.

Comments (2)

TEMP-ad avatar TEMP-ad commented on June 23, 2024

This is causing any tab pinned or unpinned to get the interstitial message.

1.68.36 Chromium: 125.0.6422.76 (Official Build) nightly (64-bit) Windows 11 Version 23H2 (Build 22631.3593)

How to reproduce:

  1. just have some tabs opened
  2. pin some
  3. open a new window
  4. click on the pinned tabs in the new window.
  5. see how the active tab in the original window gets the message about the tab being shared
  6. the only way is to go to the original window and change tabs, if you click on the interstitial message nothing will happen, it will only switch between pinned tabs if you are on the correct pinned tab.
Recording.2024-05-22.182016.mp4

from brave-browser.

sangwoo108 avatar sangwoo108 commented on June 23, 2024

Hi @TEMP-ad ! Thanks for reporting. That might be only happening on Windows. It should be replaced as soon as the window is activated. Let me take a look asap.


I was wrong. We shouldn't install the interstitial page when the shared pinned tab is not the active tab.

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.