Comments (2)
bennettmsherman
commented on July 22, 2024
I'm not familiar with Android development or the Chromium/Brave source, but I suspect it has to do with this change:
added in #23298
I suspect Chromium's version of shouldShowNewWindow() was returning true, but BraveMultiWindowUtils.shouldEnableMultiWindows() is now returning false (and by extension, so is shouldShowNewWindow())
from brave-browser.
bennettmsherman
commented on July 22, 2024
I suspect the issue boils down to: whatever logic is used to determine when the New Window option is present in Chrome (and formerly Brave) is not similarly being used to determine when the Enable multiple windows preference is available in Brave. This means I can't turn on Enable multiple windows, which means shouldEnableMultiWindows() is always false, which in turn means shouldShowNewWindow() is also always false.
from brave-browser.
Related Issues (20)
- Add iOS News MAU/DAU metrics
- [Follow up to #37348] When device language/region is set to the allowlisted country (ex. USA) it is possible to enable `Rewards` for `Russia` and `Ukraine` HOT 6
- Update wallet portfolio chart to remove allow-same-origin sandbox attribute
- [Android] Parallel downloading setting
- [ads] Favicon found report to rewards if when `shouldNotifyAdsServiceTabContentDidChange` is false
- Action Extension not triggering for txt file
- Enable Bitcoin by default on iOS
- The secure status icon for unknown SSL status is wrong on iOS HOT 2
- Long title text of a Bookmark in the Bookmarks list is missing and/or faded out
- Search engine favicon should be updated when a different search engine is selected via customize dashboard HOT 1
- Disabling `Close window when closing last tab` breaks `Bring all tabs to this window` functionality.
- [CR 126] change `Switch to this tab` text/border colour - follow up of #38731 HOT 2
- [CR 126] Enable `Reading List` sub menu HOT 2
- [ZCash] Switch to another zcash endpoint HOT 3
- (Feature) Single-window mode
- Address bar appearance bug
- [ads] Brave News inline ads with the same placement id are shown in new tabs
- Leo - Add system standard context menu for query entry field
- Test failure: TransactionConfirmationStoreTests.testPrepareBTCSend()
- [iOS] - Support Multi-Device Skus Payments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave-browser.