Giter Site home page Giter Site logo

Comments (11)

GeetaSarvadnya avatar GeetaSarvadnya commented on July 22, 2024 1

I have two windows 10 x64 machines. In one machine the Exit button is shown and in other machine the Exit option isn't shown. Based on the system resolution, the exit option is shown.

Machine 1 - Windows 10 x64 - The Exit menu option isn't shown with default 150 % recommended resolution

Example Example
image image

If I change the 150 % recommended resolution to 125% I can see the exit menu option via hamburger menu

Example Example
image image

Machine 2 - Windows 10 x64 - The Exit menu option is shown with default 125 % recommended resolution

Example Example
image image

from brave-browser.

GeetaSarvadnya avatar GeetaSarvadnya commented on July 22, 2024 1

Chrome Vs Brave
chrome exit Vs Brave exit

from brave-browser.

emerick avatar emerick commented on July 22, 2024

I can't repro this with nightly on Windows 11. According to the upstream code, the "Exit" menu should show on Windows and be hidden on Mac which is what I'm seeing.

from brave-browser.

GeetaSarvadnya avatar GeetaSarvadnya commented on July 22, 2024

I can see Exit menu option on Hamburger menu on Windows 11x64, but not on Windows 10 x64. Looks like windows 10 x64 specific issue.

from brave-browser.

stephendonner avatar stephendonner commented on July 22, 2024

I just installed

Brave | 1.68.58 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
-- | --
Revision | ec786b623be34c911487c24144c0650bdd057fc1
OS | Windows 10 Version 22H2 (Build 19045.4412)

The Exit option is there for me 👍

image

from brave-browser.

GeetaSarvadnya avatar GeetaSarvadnya commented on July 22, 2024

cc: @emerick @rebron #38587 (comment)

from brave-browser.

emerick avatar emerick commented on July 22, 2024

Oh, is that because at the increased resolution the menu becomes scrollable (i.e., the Exit option scrolled off the end and maybe the scrollbar is not visible?) That's the only conceivable option I can imagine, because the menu item "should" physically be there.

from brave-browser.

GeetaSarvadnya avatar GeetaSarvadnya commented on July 22, 2024

@emerick : With CR126, the hamburger menu items are increased, this is also one of the reason why the menu item Exit is not shown with default (recommended) resolution.
exit menu issue

from brave-browser.

stephendonner avatar stephendonner commented on July 22, 2024

Oh, is that because at the increased resolution the menu becomes scrollable (i.e., the Exit option scrolled off the end and maybe the scrollbar is not visible?) That's the only conceivable option I can imagine, because the menu item "should" physically be there.

@emerick this is how it is for me, yes:

  • invisible scrollbar
  • X Exit below Settings

from brave-browser.

stephendonner avatar stephendonner commented on July 22, 2024

Oh, is that because at the increased resolution the menu becomes scrollable (i.e., the Exit option scrolled off the end and maybe the scrollbar is not visible?) That's the only conceivable option I can imagine, because the menu item "should" physically be there.

@emerick this is how it is for me, yes:

  • invisible scrollbar
  • X Exit below Settings
2024-05-30_09h27_06.mp4

from brave-browser.

stephendonner avatar stephendonner commented on July 22, 2024

And Chrome has this little expand arrow

image

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.