CR 126 - Install Password Manager icon and the modal popup buttons are inherited from chrome

[GeetaSarvadnya]

CR 126 - Install Password Manager icon and the modal popup buttons are inherited from chrome

[aguscruiz]

The actions in the dialog should always be:

• Primary action on the right, using filled button
• Dismissive action (in this case cancel) in plain-faint buttons, on the left

[aguscruiz]

Yeah, we need to make this pattern the default. I'll create an issue for defining that

[GeetaSarvadnya]

@emerick: I don't have any issues with new icon if @rebron and @aguscruiz are ok with it.

[GeetaSarvadnya]

same issue on the page below:

[aguscruiz]

General issue here:
#38603

[kjozwiak]

The above requires 1.67.101 or higher for 1.67.x verification 👍

[GeetaSarvadnya]

@emerick: I can see the old Install Password Manager popup modal, but icon in the URL bar is still inherited from chrome.

[emerick]

@GeetaSarvadnya Sorry, I missed the icon when I did this. Working on it now.

[emerick]

@GeetaSarvadnya @rebron Actually, looking deeper into this...is there any reason not to go with the refresh icon? To me, the new icon makes it much clearer that something is being downloaded/installed and the old icon was not a "Brave" icon to begin with. Happy to change it back of course, just wondering if it actually make sense in this particular scenario.

[aguscruiz]

I'm ok with the download icon, makes it clear. But let's use our version of it, in Nala, called pwa-install