Comments (4)
fallaciousreasoning
commented on September 28, 2024
2
@emerick that's fine - @aguscruiz squared all the squircles :D
from brave-browser.
emerick
commented on September 28, 2024
1
This change is due to the kImprovedDownloadPageWarnings which is now enabled by default. I'm pushing a PR that disables that setting which restores the old UI, but the buttons seem a little bit squared off to me. Not sure if that's acceptable or not. Might need someone like @fallaciousreasoning to take a look, if not.
This is what they look like with my change
from brave-browser.
kjozwiak
commented on September 28, 2024
The above requires 1.67.101 or higher for 1.67.x verification 👍
from brave-browser.
MadhaviSeelam
commented on September 28, 2024
Verification PASSED using
Brave | 1.67.101 Chromium: 126.0.6478.26 (Official Build) beta (64-bit)
-- | --
Revision | a561f4b53cdb831888e5cd702d2b8f9598c00f50
OS | Windows 11 Version 23H2 (Build 22631.3672)
Verified using the STR from issue description #38657 (comment)
Confirmed Remove from list and Keep dangerous file buttons are shown for dangerous file downloads
Confirmed Download page buttons (Pause, Cancel, Resume, Retry) are shown and working as expected
| example | example | example | example | example | example |
|---|---|---|---|---|---|
from brave-browser.
Related Issues (20)
- fix colors on "Make Brave Faster" modal
- [Follow up to #39169] Paths contain percent encoding making path-based file I/O API calls fail HOT 1
- Nightly crash on macOS - 1.70.66 HOT 2
- Crash Report HOT 1
- Crash Report HOT 2
- Crash Report HOT 6
- Crash Report HOT 1
- [Android] Update title for search suggestions
- Add new UD TLDs
- [ads] Transition purchase intent history from `client.json` to a database table
- Deprecate old patterns for component installers
- Test failure: CommandUtilsBrowserTest.AllCommandsShouldBeExecutableWithoutCrash HOT 3
- Missing FOREGROUND_SERVICE_SPECIAL_USE
- Add metric for Ads clear data action
- Use `brave_l10n::GetDefaultISOCountryCodeString` for NTT + iOS P3A country code
- Can't grab the border around the vertical tab area for resizing window HOT 1
- Sometimes doesn’t save the active tab correctly when quitting Brave HOT 2
- Cannot enabled password as sync item HOT 4
- YouTube video settings don't work in full screen mode HOT 7
- Update l10n for 1.69.x (Chromium 128). Part II. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave-browser.