Giter Site home page Giter Site logo

Comments (3)

SergeyZhukovsky avatar SergeyZhukovsky commented on August 16, 2024

We actually want to remove pre-defined fav icons for now to avoid pings to thrid parties on initial start.

from brave-browser.

kjozwiak avatar kjozwiak commented on August 16, 2024

The above requires 1.68.123 or higher for 1.68.x verification 👍 @hffvld @Uni-verse can use brave/brave-core#24511 (comment) as a template for 1.68.x verification. But we should check both mobile & tablet as well.

from brave-browser.

kjozwiak avatar kjozwiak commented on August 16, 2024

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.68.125 Chromium: 127.0.6533.57 (Official Build) (64-bit)
--- | ---
Revision | 14ff4d467fb3eec4e6fc0a2f3e2d3f7b4c8cb788
OS | Android 15; Build/AP31.240517.031; 35; REL
  • ensured that the pre-determined websites based on region are not being populated via NTP on first launch
  • ensured that there's no websites being displayed/being loaded when opening several NTP
  • ensured that there's no connections to websites like bestbuy.com, facebook.com & amazon.com via Proxyman
  • ensured that once you start visiting several websites, the most popular/visited ones get loaded into Favorites
  • upgraded from 1.67.123 Chromium: 126.0.6478.126 -> 1.68.125 Chromium: 127.0.6533.57 and ensured that the previous Favorites under NTP weren't affected after upgrading

Also checked the following scenario to ensure that Favorites are still being added into the NTP:

  • download/install 1.67.123 Chromium: 126.0.6478.126 and notice the pre-populated Favorites on the second NTP
  • upgrade to 1.68.125 Chromium: 127.0.6533.57 and notice that all the pre-populated Favorites have been removed
  • visited several websites ~3-4 times each and ensured that the website was added into Favorites under NTP

Also ensured that previous Favorites that have been added by the user are not removed/affected after upgrading.

Example Example Example Example
Screenshot 2024-07-19 at 4 07 40 PM Screenshot_20240719-160726 Screenshot_20240719-160731 Screenshot_20240719-161213

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 14 using the following build(s):

Brave | 1.68.125 Chromium: 127.0.6533.57 (Official Build) (64-bit)
--- | ---
Revision | 14ff4d467fb3eec4e6fc0a2f3e2d3f7b4c8cb788
OS | Android 14; Build/UP1A.231005.007; 34; REL
  • ensured that the pre-determined websites based on region are not being populated via NTP on first launch
  • ensured that there's no websites being displayed/being loaded when opening several NTP
  • ensured that there's no connections to websites like bestbuy.com, facebook.com & amazon.com via Proxyman
  • ensured that once you start visiting several websites, the most popular/visited ones get loaded into Favorites
  • upgraded from 1.67.123 Chromium: 126.0.6478.126 -> 1.68.125 Chromium: 127.0.6533.57 and ensured that the previous Favorites under NTP weren't affected after upgrading

Also checked the following scenario to ensure that Favorites are still being added into the NTP:

  • download/install 1.67.123 Chromium: 126.0.6478.126 and notice the pre-populated Favorites on the second NTP
  • upgrade to 1.68.125 Chromium: 127.0.6533.57 and notice that all the pre-populated Favorites have been removed
  • visited several websites ~3-4 times each and ensured that the website was added into Favorites under NTP

Also ensured that previous Favorites that have been added by the user are not removed/affected after upgrading.

Example Example Example Example
Screenshot 2024-07-19 at 4 39 43 PM Screenshot_20240719_164052_Brave Screenshot_20240719_164510_Brave Screenshot_20240719_164055_Brave

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.