Comments (3)
We actually want to remove pre-defined fav icons for now to avoid pings to thrid parties on initial start.
from brave-browser.
The above requires 1.68.123
or higher for 1.68.x
verification 👍 @hffvld @Uni-verse can use brave/brave-core#24511 (comment) as a template for 1.68.x
verification. But we should check both mobile
& tablet
as well.
from brave-browser.
Verification PASSED on Pixel 6 Pro
running Android 15
using the following build(s):
Brave | 1.68.125 Chromium: 127.0.6533.57 (Official Build) (64-bit)
--- | ---
Revision | 14ff4d467fb3eec4e6fc0a2f3e2d3f7b4c8cb788
OS | Android 15; Build/AP31.240517.031; 35; REL
- ensured that the pre-determined websites based on region are not being populated via NTP on first launch
- ensured that there's no websites being displayed/being loaded when opening several NTP
- ensured that there's no connections to websites like
bestbuy.com
,facebook.com
&amazon.com
viaProxyman
- ensured that once you start visiting several websites, the most popular/visited ones get loaded into
Favorites
- upgraded from
1.67.123 Chromium: 126.0.6478.126
->1.68.125 Chromium: 127.0.6533.57
and ensured that the previousFavorites
under NTP weren't affected after upgrading
Also checked the following scenario to ensure that Favorites
are still being added into the NTP:
- download/install
1.67.123 Chromium: 126.0.6478.126
and notice the pre-populatedFavorites
on the second NTP - upgrade to
1.68.125 Chromium: 127.0.6533.57
and notice that all the pre-populatedFavorites
have been removed - visited several websites ~3-4 times each and ensured that the website was added into
Favorites
under NTP
Also ensured that previous Favorites
that have been added by the user are not removed/affected after upgrading.
Example |
Example |
Example |
Example |
---|---|---|---|
Verification PASSED on Samsung Galaxy Tab S8 Ultra
running Android 14
using the following build(s):
Brave | 1.68.125 Chromium: 127.0.6533.57 (Official Build) (64-bit)
--- | ---
Revision | 14ff4d467fb3eec4e6fc0a2f3e2d3f7b4c8cb788
OS | Android 14; Build/UP1A.231005.007; 34; REL
- ensured that the pre-determined websites based on region are not being populated via NTP on first launch
- ensured that there's no websites being displayed/being loaded when opening several NTP
- ensured that there's no connections to websites like
bestbuy.com
,facebook.com
&amazon.com
viaProxyman
- ensured that once you start visiting several websites, the most popular/visited ones get loaded into
Favorites
- upgraded from
1.67.123 Chromium: 126.0.6478.126
->1.68.125 Chromium: 127.0.6533.57
and ensured that the previousFavorites
under NTP weren't affected after upgrading
Also checked the following scenario to ensure that Favorites
are still being added into the NTP:
- download/install
1.67.123 Chromium: 126.0.6478.126
and notice the pre-populatedFavorites
on the second NTP - upgrade to
1.68.125 Chromium: 127.0.6533.57
and notice that all the pre-populatedFavorites
have been removed - visited several websites ~3-4 times each and ensured that the website was added into
Favorites
under NTP
Also ensured that previous Favorites
that have been added by the user are not removed/affected after upgrading.
Example |
Example |
Example |
Example |
---|---|---|---|
from brave-browser.
Related Issues (20)
- Manual test run on Android ARM for 1.69.x - Release HOT 1
- Manual test run on Android Tab for 1.69.x - Release
- Test failure: Pending Transaction Panel EVM Simulations should show the retry button if the transaction simulation fails.Pending Transaction Panel EVM Simulations should show the retry button if the transaction simulation fails
- BSD: platform Support
- [Shred] Tab and data not deleted when using 'App Close' for Auto Shred
- Natural reader
- [C128] Inactive tab hover is incorrect HOT 1
- Brave STILL crashes 5 times a day.
- help users understand that fingerprinting protections manu does not imply a fingerprinting attack
- Unable to transfer SPL NFTs
- [Nala]: Update to use new color provider
- Enabling Speedreader causes blogs/pages to go blank. HOT 1
- Test failure: BraveRealboxHandlerTest.BraveSearchUsesNewTabSource
- Unresponsive on first launch/new profile - Win 11
- macOS: Some Meta keys are prevent from being recorded with JavaScript
- Add separator between networks in network selection screen
- Changing theme via system settings, Networks list is not shown
- Unify build and create_dist commands
- `Invalid URL` message is not shown when entering `http` for RPC, Explorer and Image
- remove code for Cookie List Opt-In if no longer needed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave-browser.