Comments (16)
@minkyeongshin — can you drop a screenshot of your design mock once it's ready? That way I'll know how much real estate I have to work with, in terms of character count.
from brave-talk.
@rmcfadden3 - sorry for the confusion: at the present time, the design "ask" is only for an icon to go in the toolbar:
initially, we're planning to use the Jitsi showNotification API call. so you can have a "reasonable" amount of text (say up to 300 characters).
in the future we may implement our own notification routine, but for now, we're focusing on the functionality... thanks!
from brave-talk.
Is this actually possible with the JAAS API? https://developer.8x8.com/jaas/docs/customize-ui-buttons links to list of button names
from brave-talk.
Well we can brand the default icons as described at https://developer.8x8.com/jaas/docs/jaas-prefs-advanced-branding#branding-data-payload - but are we able to create a new icon or do we have to be sneaky and misuse an existing icon?
from brave-talk.
https://github.com/jitsi/jitsi-meet/blob/a76f9d548b2cfceaf335250867b88a41667107e0/config.js#L949
You can use a data URL or any URL to an icon.
from brave-talk.
Thanks. Please remind me: what handler triggers when a button is pressed (presumably indexed by id
)... sorry for not knowing this stuff better by now...
from brave-talk.
Here you go! https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe-events#toolbarbuttonclicked
from brave-talk.
Thank you!
from brave-talk.
I see, I was looking at the wrong documentation (developer.8x8.com rather than jitsi.github.io) and there is in fact a customToolbarButtons config option.
from brave-talk.
OK I managed to add Leo to customToolbarButtons
and buttonsWithNotifyClick
and added an event handler.
![image](https://private-user-images.githubusercontent.com/5838651/320690168-eede92af-6f3e-44da-adfa-6b2f64273884.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjE1MDgsIm5iZiI6MTcxOTQyMTIwOCwicGF0aCI6Ii81ODM4NjUxLzMyMDY5MDE2OC1lZWRlOTJhZi02ZjNlLTQ0ZGEtYWRmYS02YjJmNjQyNzM4ODQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjZUMTcwMDA4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDI3Y2VhMzI4MTI4YmMzOGFlOTc0YzVlMzZiZDBlYTUxZGJhYmRhYTc3MjhjNGVlYzNhMWQ0NTY5MTg3OTdjZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.WsMzyzYmXviSAIJvMnE9WrVWK8PBVxH9IEWv7TX3uhA)
But the button only appears in the toolbar menu rather than the main toolbar. I'm not yet sure how to customise which buttons appear at the bottom of the screen.
from brave-talk.
OK, I think some config can be done via executeCommand('overwriteConfig',{toolbarButtons: [
. But where do we specify the initial order of microphone, camera, desktop, chat, raisehand... is that just the default?
![image](https://private-user-images.githubusercontent.com/5838651/320698861-8cf3ba45-b4be-47e6-a983-a56fb589006c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjE1MDgsIm5iZiI6MTcxOTQyMTIwOCwicGF0aCI6Ii81ODM4NjUxLzMyMDY5ODg2MS04Y2YzYmE0NS1iNGJlLTQ3ZTYtYTk4My1hNTZmYjU4OTAwNmMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjZUMTcwMDA4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2Q1MTFhZDgzMjE4NjZjOWM0NzhjMGZmYzM0YmU4MmYzZWE2NzkyN2MzYjBkN2U4ODQxZTJlODViOWVkZmNjOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.XUu3voNhdGQiPwj-C6xGnsZBAtVNmTD59Gv1ax4gMNs)
// Notes:
// - it's impossible to choose which buttons go in the "More actions" menu
// - it's impossible to control the placement of buttons
from brave-talk.
Ah OK the order is defined here: https://github.com/jitsi/jitsi-meet/blob/b54cec8d77fee77218378532bfac665e75289f90/react/features/toolbox/functions.web.ts#L410-L442
So the Leo icon will always be at the end of the "More Actions" menu and we can't move it without either:
- removing a lot of buttons like in the screenshot above
- or replacing a load of inbuilt buttons with custom versions. This wouldn't work for the
raisehand
orreactions
, but we could place the Leo button at the end of the main toolbar.
Overall, probably worth just starting with it at the end of the More Actions menu.
from brave-talk.
Just to clarify, the button should appear for context.user.moderator === true && context.features.transcription === true
from brave-talk.
Current state:
I don't believe there is currently a way to move the button onto the main bar.
I was able to get the following:
Only by deleting all the toolbar buttons which appear in More Actions. Since we need those buttons, we have a problem.
from brave-talk.
Sorry I mislead you. I can confirm this is not currenrly possible. We'll work on making it possible.
from brave-talk.
@saghul - Understood. Thanks for working on it.
from brave-talk.
Related Issues (20)
- Confused :: Why Brave-talk === Jitsi? HOT 3
- Entering insanely large input value causes the Send crypto message to be malformed
- Question: Are the (same) meeting links reused? HOT 9
- Turn on end-to-end encryption by default? HOT 1
- Log-in loads 8x8 SSO page HOT 7
- for non-premium rooms, keep track of participants not JWTs issued HOT 1
- Brave talk timer doesn't start at zero HOT 2
- Brave talk call full with only two people? HOT 2
- Does BraveTalk collect/store any statistics (with/without technical issues) HOT 2
- If a recording is in progress, and the moderator leaves, use `askOnUnload` to confirm exit
- When autoplay is disabled in the browser, audio and video don't work in Talk and the user is not told why, or what to do about it HOT 5
- Make NFT lists scrollable HOT 5
- [Feature request] Allow to share your screen on mobile HOT 2
- add default transcript
- Change text on home page HOT 1
- Add transcript view page
- README file link issues
- [Feature request] Whiteboard with real-time collaboration and E2EE HOT 1
- Change free trial to 7 days HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave-talk.