Comments (6)
Here is some example code to reproduce the problem. You'll notice the success callbacks are never fired.
from sidekiq-batch.
Stale issue message
from sidekiq-batch.
If a job inside of a batch is retried, the
on_complete
callback will be fired (before the failed job is retried) but theon_success
callback will never fire, even after the failed job is retried successfully.
Did this issue got resolved? I'm still facing this issue.
from sidekiq-batch.
Hi, if I underestand right, this even had a reproduction script (nice!), and is still not fixed, but was closed just for being stale?
If known bugs don't receive any maintainer attention and are closed for being stale without being fixed, the impression given to someone perusing the project to see it's maintenance status... is that the project is not really being maintained?
I'm not sure if this is an accurate impression or not? I am just perusing the project to get a sense of it's maintenance status.
Reopening the issue, if it is indeed still a problem, might be in order?
from sidekiq-batch.
I realized this is happening for us as well. I started to dig around why it was happening. From what I can tell right now when the complete
callback gets called it will alway set the batch event key to true
which prevents the complete
callback from performing the success
callback. I'm hoping to get some more time this weekend to play around and open a PR.
https://github.com/breamware/sidekiq-batch/blob/master/lib/sidekiq/batch.rb#L211
from sidekiq-batch.
Stale issue message
from sidekiq-batch.
Related Issues (20)
- Batches Tab HOT 2
- On complete is called while there are pending jobs HOT 2
- Add support for on_death callback HOT 2
- Deprecation messages in the logs HOT 1
- Non-safe JSON arguments Sidekiq warning HOT 3
- `cleanup_redis` should not be called immediately after batch finishes HOT 3
- Deprecations in logs HOT 1
- Incorrect logic in valid? method HOT 1
- Web UI? HOT 1
- command_builder should should allow SADD to pass an array as an argument HOT 1
- 0.1.9 incompatible with redis-client which is used by sidekiq 7 HOT 9
- Callback success fired too soon with ActionMailer HOT 2
- Job never gets set to complete and stats get deleted HOT 7
- Stubbing in rspec in tests HOT 2
- RSpec testing and Stats not updating HOT 1
- How to poll batch status ? HOT 1
- Callback is triggered just after perform is call HOT 1
- Support for Sidekiq::BatchSet HOT 1
- on_success callback is fired when some workers are still ongoing HOT 1
- Error: Unsupported command argument type: TrueClass HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sidekiq-batch.