sp_BlitzQueryStore: What is this comment trying to say?

[ReeceGoding]

sp_BlitzQueryStore: What is this comment trying to say?

[erikdarlingdata]

@ReeceGoding I may have not been feeling 100% myself when I wrote that comment 🥴

It should probably be something like:

This looks for queries in the results so far that have multiple plans in Query Store.

The rest of that comment is sort of useless, but at the time I was happy that Query Store logged certain plan attributes in columns, where they had to be parsed out of the plan XML in sp_BlitzCache. It made doing the checks simpler.

[ReeceGoding]

Thanks @erikdarlingdata . While we're on the topic of this code block, is there any chance that the COUNT(qsp.plan_id) part should be COUNT(DISTINCT qsp.plan_id) (with whatever syntax tricks are needed to make that valid)? I need to take a closer look at it, but my intuition won't shut up about it.

[erikdarlingdata]

@ReeceGoding maybe, but I haven't looked at this procedure in about 5 years.