Comments (2)
Good point. I think perhaps instead of mixing these API's - and dealing with the consequences of SingleChooser having a chooseNone but not a chooseAll - I think I should make .unchoose() not require passing in a model.
Calling unchoose without any arguments should automatically unchoose the chosen model. It get's a little hairy dealing with the options argument, but I can build the unchoose API to accept either a model to unchoose, or no model at all, and an options argument regardless.
Would that suffice your use case?
from backbone.chooser.
The method overloading option is cool.
However, personally I've tried to move away from that and create explicit methods. With that being said, a cleaner option I think would be to rename chooseNone
to clearChosen
. That naming pattern follows other methods like getChosen
.
from backbone.chooser.
Related Issues (7)
- Unit Tests HOT 1
- bug in collection.unchoose(models, [options])
- Move model chosen flag to internal property. HOT 1
- SingleChooser - add the ability to unchoose a selected model
- doc typo: toggleChosen() => toggleChoose();
- "collection:unchose:one" event should be fired when you choose a new model in SingleChooser
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone.chooser.