Giter Site home page Giter Site logo

Comments (2)

brian-mann avatar brian-mann commented on August 11, 2024

Good point. I think perhaps instead of mixing these API's - and dealing with the consequences of SingleChooser having a chooseNone but not a chooseAll - I think I should make .unchoose() not require passing in a model.

Calling unchoose without any arguments should automatically unchoose the chosen model. It get's a little hairy dealing with the options argument, but I can build the unchoose API to accept either a model to unchoose, or no model at all, and an options argument regardless.

Would that suffice your use case?

from backbone.chooser.

jgornick avatar jgornick commented on August 11, 2024

The method overloading option is cool.

However, personally I've tried to move away from that and create explicit methods. With that being said, a cleaner option I think would be to rename chooseNone to clearChosen. That naming pattern follows other methods like getChosen.

from backbone.chooser.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.