Giter Site home page Giter Site logo

Comments (13)

Threpio avatar Threpio commented on June 13, 2024 1

--Album can be for a future PR.

I won't be able to do this this evening but am happy to look at it this weekend :)

Edit:
For clarity should I not be calling the GetPlaylist (singular) function so that we can have the Params as part of this?

Do we want this as a flag on play or
Playlists?

from spotify-cli.

brianstrauch avatar brianstrauch commented on June 13, 2024 1

@Threpio Commented on your PR, but we can add context_uri to the existing Play() function.

from spotify-cli.

Threpio avatar Threpio commented on June 13, 2024

Is anyone working on the playing of a playlist?

Also curious as to see if there is the possibility of implementing the ability to see the 'Liked songs' playlist (I use that for my spotify usage.

from spotify-cli.

brianstrauch avatar brianstrauch commented on June 13, 2024

Created an issue for playing the "Liked Songs" playlist! 😄 Although, this issue has to be completed first. Let me know if you're interested in working on it and I'll assign it to you. @Threpio

from spotify-cli.

Threpio avatar Threpio commented on June 13, 2024

Was having a look at the codebase whilst I was curious - Not 100% sure I know how to apply it straight up. The generic Spotify libraries don't seem to support referencing a playlist as a command/variable.
If I think I can take it on I will ping and take it - For the meanwhile it might be worth leaving it to someone a bit more experienced.

from spotify-cli.

Threpio avatar Threpio commented on June 13, 2024

I didn't realise that you were referencing your own Spotify go api library. Do we need to create the 'play playlist' functionality there and then update the reference/commands here? Sorry for the time

from spotify-cli.

brianstrauch avatar brianstrauch commented on June 13, 2024

@Threpio No worries, the only change you'd have to implement in the library is searching by playlist/album (which should be relatively simple; just a few lines of code). It currently hardcodes "track" in the search parameters: https://github.com/brianstrauch/spotify/blob/5e406af4be1b0cc7d6fb0cdec0288bb09013d77c/search.go#L13

from spotify-cli.

Threpio avatar Threpio commented on June 13, 2024

Screenshot 2021-07-16 at 17 44 11

A first stab at the changes to the spotify library - This could then be called in here. I think I was just going to reference the 'GetPlaylist' Function that had already been created?

EDIT: I have realised that this only returns playlists of the user - I assume other playlists being played will be needed aswell.

from spotify-cli.

brianstrauch avatar brianstrauch commented on June 13, 2024

@Threpio Actually... I think we can just use the existing api.Play() function! That function takes a variable number of uris, so you could probably just pass the URI of a playlist into the function and it would play that playlist. We would just have to make a new api.SearchForPlaylist() function to return a URI for a given playlist name.

from spotify-cli.

Threpio avatar Threpio commented on June 13, 2024

the GetPlaylist function returns a Playlist object - Which I believe contains the URI?

playlist.Meta.URI

from spotify-cli.

brianstrauch avatar brianstrauch commented on June 13, 2024

@Threpio Hmm... I was originally thinking we could give people the option to play any playlist, but being able to play only your own playlists is probably better for UX. In that case, we should call the api.GetPlaylists() function and do a case-insensitive search for the playlist name the user gave us. If we find it, we can grab the URI value and pass that to the Play() function.

So, the good news is that we won't have to implement anything new in the SDK, just the CLI. 😄

from spotify-cli.

brianstrauch avatar brianstrauch commented on June 13, 2024

Although the --album flag will need to implement a new Search() function. I'll split that off into a new issue

from spotify-cli.

Threpio avatar Threpio commented on June 13, 2024

Screenshot 2021-07-17 at 10 46 22

I believe that a small change will be needed to the spotify library and it can't just be done here. The api.Play() function can take uri's of songs but a playlist or album requires a 'context_uri' field that we do not currently send?

from spotify-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.