Add some generic number type when you don't know if the result will be `int` or `decimal`

[matronator]

Add some generic number type when you don't know if the result will be `int` or `decimal`

[BenMorel]

Hi, this could have been BigNumber, which already knows how to handle comparison between types, and cross-type additions (see BigNumber::sum().

That being said, plus(), minus() etc. are already defined on subclasses, and they return an instance of the subclass. We cannot move the implementation to BigNumber, and make each operation return a potentially different type than the type you call the method on, without drastically changing the behaviour of the library (for the worse, IMO).

So this would need to be a new class indeed. But it comes with its own challenges: only addition / subtraction / multiplication could be implemented on this class, as the signature of dividedBy() in each number class is different:

• BigRational::dividedBy() only needs a divisor
• BigInteger::dividedBy() needs a divisor and a rounding mode
• BigDecimal::dividedBy() needs a divisor, a scale and a rounding mode

I'm wondering, if you're re-writing a TS library to PHP, are you dealing with number types? Or with arbitrary precision?
In the former case, the equivalent would just be using float in PHP. AFAIK, Both PHP's float and JS' number are IEEE 754 double-precision numbers, so you should observe the same behaviour (and the same gotchas, obviously).