Add validation to ensure sum of accepted payments is equal to the order total

[phillipuniverse]

Add validation to ensure sum of accepted payments is equal to the order total

[phillipuniverse]

@apazzolini I believe this has actually been resolved when we did those payment activity refactorings. Could you confirm and if it's resolved could you close?

[apazzolini]

I think this is payment module specific. @Jerry77oz can you confirm this is resolved for Braintree? We should ensure all modules are fixed, or figure out a way to enforce it in core.

[ktisdell]

There may be multiple payment modules used in a single transaction (e.g. Braintree and Account Credit), so I assume that this has to be enforced in core.

[Jerry77oz]

This has been addressed in core, as there is now a check on PaymentActivity to verify the amount processed by the payment module. If an amount is returned for less then what was in the PaymentInfo then an Insufficient Funds error is thrown.

[phillipuniverse]

@apazzolini looks like the referenced commit ensures that after the payment workflow is completed, all order funds have been paid for. Line 71 looks like it does the job. Feel free to close if so.