Symfony Bundle broken due to invalid service definition

[broadway]

Symfony Bundle broken due to invalid service definition

[mbadolato]

As a temporary workaround, for anyone that needs it, re-defining the service in your application's ownservices.xml file overwrites the broadway definition and seems to work.

<service id="broadway.auditing.command_logger" class="Broadway\Auditing\CommandLogger">
    <argument type="service" id="monolog.logger" />
    <argument type="service" id="broadway.auditing.serializer" />
    <tag name="broadway.event_listener" event="broadway.command_handling.command_success" method="onCommandHandlingSuccess" />
    <tag name="broadway.event_listener" event="broadway.command_handling.command_failure" method="onCommandHandlingFailure" />
</service>

Though I don't know that there are guarantees that that's always a the case or if it just depends on the order in which Symfony manages to rebuild the service container (i,e., I don't know if there's a defined processing order or if it's possible that your services.xml could be parsed first then overwritten by the Broadway definition).

[wjzijderveld]

Actually, it is dynamically injected: https://github.com/qandidate-labs/broadway/blob/master/src/Broadway/Bundle/BroadwayBundle/DependencyInjection/BroadwayExtension.php#L46-L59
So with logger: false, it should fallback to simple_command_bus.

I agree that you will end up with a non-working (and by default non-used) service with logging disabled, so we might need to remove that service in the else.

[mbadolato]

Ah, didn't dig down and see that it was dynamically created. Not so worried about it being non-used, however I did have logger set to false and it caused Symfony to hork. When I get some time this weekend, I'll see if I can dig further

[mbadolato]

Setting logger: true yields:

The service "broadway.auditing.command_logger" has a dependency on a non-existent service "1".

Edit: I'm guessing it needs an actual class/service instead of just true

Setting logger:false yields:

Catchable Fatal Error: Argument 1 passed to Broadway\Auditing\CommandLogger::__construct() must implement interface Psr\Log\LoggerInterface, string given, called in /Users/mbadolato/development/projects/example-symfony-ddd/var/cache/dev/appDevDebugProjectContainer.php on line 1078 and defined

config:

broadway:
    command_handling:
        logger: false

    read_model:
        repository: elasticsearch
        elasticsearch:
            hosts:
                - localhost:9200

    saga:
        repository: in_memory

[mbadolato]

ok, so logger: false doesn't work for me, but using the name of the monolog logger service ('logger') works. Was giving me fits; I had mistakenly tried to set it with the service "@logger" 😄

broadway:
    command_handling:
        logger: logger

[wjzijderveld]

Yes, it uses the value (when not falsey) as a direct reference, so no '@' required. As we use XML the @ probably wouldn't have worked in any situation :-)

We use this configuration in our application:

broadway:
    command_handling:
        logger: monolog.logger.commandlog

I agree this isn't the prettiest solution, but mainly a matter of missing documentation. Closing this for now.