Serialization Problems

[broadway]

Serialization Problems

[cordoval]

https://github.com/qandidate-labs/broadway/blob/master/src/Broadway/Serializer/SerializerInterface.php#L15-L16

It seems this was not built to support objects but scalars. Perhaps that can clarify the question.

I am also interested if this was done for elasticsearch, why the interface was forced to that and not support objects underneath the serialization output?

[cordoval]

I think also in https://github.com/qandidate-labs/broadway/blob/master/src/Broadway/Domain/Metadata.php#L50 when it gets serialized and the information accessible as an array then is a bit misleading. Maybe there should be a note somewhere in the docs about acknowledging that the concept of serialization is not to strings but to arrays because of elastic search and for practical reasons which would be good to list. This I say having in view that lots of users come from the background where serialization ends up in a string.

[cordoval]

one more reason to tag the package to include the metadata accessing fix on projector land from @mbadolato ! 👴

[wjzijderveld]

@Richtermeister thanks for the compliment 😄

I wasn't involved from the start, so I don't know about all the design decisions. But I'm guessing serializing to flat array is just convenient. In the end it gets saved as json in the database, which is a lot easier with arrays :-)

How we handle value object, is by calling the serialize method on those objects:

class Foo {
  private $stringProperty;
  private $valueObject;

  public function serialize() {
    return array(
      'stringProperty' => $this->stringProperty,
      'valueObject'    => $this->valueObject->serialize()
    );
  }
}

And with deserializing we reconstuct the value objects. Which usually is just instantiating it, as all properties are part of the constructor in our case.

[wjzijderveld]

@Richtermeister I'm closing this for now, if you have any further questions, please re-open or ask in our IRC channel (#qandidate on Freenode)