Look into better email template engine

[brockallen]

Look into better email template engine

[brockallen]

Not perfect, but reworked how the email notifications are generated and how the templates are stored and loaded.

[justSteve]

Curious as to how you've arrived to the current implementation. Love how the templates are organized and editable. But you went in a different direction than strongly typed, Razor-based templates. In that this issue closed 7 months ago, you've had enough time to draw conclusions on pro v. con...any thoughts to share?

thx

[brockallen]

I just built it myself -- nothing magic about it.

As for using something else, MR is more about the security not about the email templates. If you want something better or more robust, go for it, but it's not something I have time to do. If someone finds a nice way to bundle a better template engine into MR, then I'd consider a PR.

[justSteve]

Understood re: focus of MR. But since you opened this thread with a consideration of a Razor-based template and ended up implementing token-based templates, just wondering what drove that decision and any possible 2nd guesses?

[brockallen]

Well, I implemented the token replacement one first and a razor approach would be more work. In short, I am lazy.

[justSteve]

Thanks - just the answer I was looking for. thx

On Mon, Feb 3, 2014 at 12:47 PM, Brock Allen [email protected]:

Well, I implemented the token replacement one first and a razor approach
would be more work. In short, I am lazy.

Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-33985920
.