Giter Site home page Giter Site logo

Expose Faker again about peteshow HOT 7 OPEN

brousalis avatar brousalis commented on August 26, 2024
Expose Faker again

from peteshow.

Comments (7)

esambo avatar esambo commented on August 26, 2024

But why can't we make Faker globally accessible? It's a public library and not an implementation detail. It is a dependency. It is not modified by Faker and therefore probably should NOT live within the Peteshow namespace!

from peteshow.

brousalis avatar brousalis commented on August 26, 2024

It wasn't on purpose. When Kevin did the gulp changeover, he broke that on accident.

I'll fix it shortly.

from peteshow.

esambo avatar esambo commented on August 26, 2024

There seem to be some other errors too when trying to fill out a form with Peteshow

from peteshow.

brousalis avatar brousalis commented on August 26, 2024

I think its pretty safe to say Kevin's gulp implementation is broken and master is dirty. I'll revert everything.

However I never released his changes to the gem itself, so the gem is still stable.

from peteshow.

esambo avatar esambo commented on August 26, 2024

Yes, 0.8.6 (referencing ref 1d93e3f) works, and rebasing #2 onto that last commit before gulp works fine

from peteshow.

itsthatguy avatar itsthatguy commented on August 26, 2024

Hey!

from peteshow.

itsthatguy avatar itsthatguy commented on August 26, 2024

Digging into all of this now

from peteshow.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.