Giter Site home page Giter Site logo

Comments (5)

dominictarr avatar dominictarr commented on June 5, 2024

That would make sense,
if you npm install [email protected], what happens?

It works with that version you are correct - if so, can you make a pull request with a test case?

/cc @isegal

from crypto-browserify.

facundoolano avatar facundoolano commented on June 5, 2024

Works with 1.0.3, not with 1.0.4. I'm not sure what the fix would be (other than dropping Buffers), but I'll take a look at it when get the time.

from crypto-browserify.

facundoolano avatar facundoolano commented on June 5, 2024

Ok, checked the code, the problem is that hash.update builds a list of strings that digest passes to buffer.concat which expects a list of buffers.

from crypto-browserify.

mpaulucci avatar mpaulucci commented on June 5, 2024

+1

from crypto-browserify.

dominictarr avatar dominictarr commented on June 5, 2024

okay, that is merged, sorry about the delay.

from crypto-browserify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.