Crypto reference

[guybedford]

Crypto reference

[jprichardson]

Can you elaborate a little more on the problem with installing from npm?
I'm not seeing it. Thanks.

On Thu, Oct 16, 2014 at 5:24 AM, Guy Bedford [email protected]
wrote:

With the crypto reference in this line -
https://github.com/dominictarr/crypto-browserify/blob/master/rng.js#L4,
this module isn't completely standalone when installed through npm
normally. It's a minor issue but gave a few headaches working on jspm
support.

—
Reply to this email directly or view it on GitHub
#60.

Simple & Secure Bitcoin Wallet: https://www.coinbolt.com
Bitcoin / JavaScript: http://cryptocoinjs.com
Follow me on Twitter: http://twitter.com/jprichardson

[guybedford]

If statically analyzing the code, the crypto reference in the file rng.js is actually referring to the core crypto module, and not the crypto-browserify version. Thus, it is relying on the fact that an internal map has already been set up for crypto. If it used ./index then it would be fully modular. But not a major issue at all.

[dominictarr]

That exact line was already fix for this: #58
jspm needs to check for this: https://github.com/dominictarr/crypto-browserify/blob/master/package.json#L38 which tells browserify to ignore the crypto module when bundling.

[guybedford]

Thanks for clarifying - yes supporting false browser values is the right fix.