pbkdf2-compat circular dependency problem

[browserify]

pbkdf2-compat circular dependency problem

[weilu]

@dcousens any idea on how to fix this?

[dcousens]

The easy solution is obvious. But, I think we can do better. (No idea on how yet)

[killerstorm]

Now you have:

1. pbkdf2-compat code modified specifically for integration with crypto-browserify
2. pbkdf.js which is a wrapper for pbkdf2-compat
3. three lines in index.js

So there is a lot of extra code which implements integration, and it still doesn't work very well.

Isn't it obvious that it world be better if you add pbkdf2-compat code to crypto-browserify?

Sure, it's a bit ugly, but now you have a solution which is both ugly and has problems.

[dominictarr]

ah, okay the solution is quite simple, crypto-browserify needs to call

var pbkdf2 = require('pbkdf2-compat/pbkdf2') //instead of 'pbkdf2-compat'
//and then pass it self in
var tmp = pbkdf2(crypto)
crypto.pbkdf2 = tmp.pbkdf2
crypto.pbkdf2Sync = tmp.pbkdf2Sync

pbkdf2-compat only does require('crypto') from index, so this will work.

[dominictarr]

the solution was just this: 1aef109

[dominictarr]

published in [email protected]