Comments (6)
@fanatid if we documented the difference that pkbdf2
async could be higher performance... I think people would be OK with that.
from pbkdf2.
this is done
from pbkdf2.
do you have any benchmarks? I'd like to know how native browser implementation much faster
from pbkdf2.
@fanatid Not actual benchmarks, but you can browse https://deniable.website/ in Chrome and in Safari, and you can see the difference (Chrome can use native, Safari uses this package as shown in https://github.com/jjperezaguinaga/deniable-website/blob/master/scripts/pbkdf2.js). Safari overall will take from 7-8 seconds to perform 100,000 iterations.
But yeah, we should get actual benchmarks.
from pbkdf2.
I already checked deniable.website
, but I'd like to know numbers (benchmarks).
Also should note that native crypto can be used only for pbkdf2
, not for pbkdf2Sync
.
from pbkdf2.
True, without numbers it's all wishful guessing, even if positive. The statement about pbkdf2Sync
is also correct, as well as with my previous comment on only being able to use with a range of bits. Overall seems an improvement over a very little subset of cases, but I think if the numbers prove right, it would be worth it from a performance perspective. The question is whether you want to add that code that will most likely need to be maintained in the future if the spec changes (browser wise).
from pbkdf2.
Related Issues (20)
- why we need to check crypto.pbkdf2Sync.toString() ? HOT 2
- In 9.0.0, sha1 is not defaulted HOT 2
- Ripemd160 throws when used HOT 1
- Allow using this library with Uint8Array HOT 2
- DoS with long password HOT 5
- How to improve the performance HOT 2
- works on browser? HOT 2
- Can I decode it?
- version change from 3.0.7 to 3.1.0 HOT 6
- pbkdf2.pbkdf2Sync('password', 'salt', 1, 32, 'sha512') returns array not string HOT 1
- The value "NaN" is invalid for option "size" HOT 2
- Uint8Array tests fail on s390x
- Incompatibility with rn-nodeify HOT 5
- Issue in pbkdf2/lib/default-encoding.js HOT 1
- process.version is undefined in lib/default-encoding.js on electron app
- pbkdf2\lib\default-encoding.js, process.version is undefine,
- In the electronic application, when I start nodeintegration, the program appears default-encoding.js? 9f9d:10 Uncaught TypeError: Cannot read property 'split' of undefined HOT 1
- pbkdf2 failing on some development environments
- pbkdf2\lib\default-encoding.js, Unexpected token (5:36) HOT 1
- Please consider upgrading the default hash function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pbkdf2.