Comments (15)
hi, you can check #60
from pbkdf2.
same issue, tried with 3.0.10 and that's broken as well.
from pbkdf2.
@Incanus3 i managed to get it working by forcing 3.0.9
from pbkdf2.
So did I, after I finally found the source of the problem. At least this will force me to use yarn instead of npm. If I had yarn.lock, I could've found it much sooner.
from pbkdf2.
The update to add this check completely breaks Webpack since it ultimately utilizes this package for crypto.
from pbkdf2.
shoulf be fixed
from pbkdf2.
Not fixed. The problem is the core functionality in Webpack depends on this code not throwing an error. When the crypto.pbkdf2Sync value is undefined Webpack was OK with that especially if you did not really need to use the pbkdf2 method. Now what happens is there is an error thrown by the browser because crypto.pbkdf2Sync is actually undefined when using Webpack. Even if that did not error out, when the updated code throws an error, the code still breaks running Webpack bundles.
from pbkdf2.
@danbrianwhite are you getting an error in version 3.0.12 and if so what is it?
from pbkdf2.
@calvinmetcalf when crypto is required, it does not have the key pbkdf2Sync. This key is undefined which throws a JS error because the value is undefined. Even if that undefined value is checked for, it will still break Webpack because it expects not to be thrown and the code will now be thrown because of this commit
from pbkdf2.
what exactly is your config, that file shouldn't even be loaded in the first place because of the browser field in the package.json
from pbkdf2.
that's what #62 fixed
from pbkdf2.
@calvinmetcalf Thank you for following up with me. The issue is indeed fixed now with v 3.0.12 - it looks like it took a little time to propagate through my cache. Thank you for fixing the issue.
from pbkdf2.
@calvinmetcalf seems like you had fun overnight.
Everything looks good now?
Anything published/unpublished?
from pbkdf2.
I believe it's all fine now
from pbkdf2.
basically I forgot to update browser object so it was pointing at the wrong file
from pbkdf2.
Related Issues (20)
- why we need to check crypto.pbkdf2Sync.toString() ? HOT 2
- In 9.0.0, sha1 is not defaulted HOT 2
- Ripemd160 throws when used HOT 1
- Allow using this library with Uint8Array HOT 2
- DoS with long password HOT 5
- How to improve the performance HOT 2
- works on browser? HOT 2
- Can I decode it?
- version change from 3.0.7 to 3.1.0 HOT 6
- pbkdf2.pbkdf2Sync('password', 'salt', 1, 32, 'sha512') returns array not string HOT 1
- The value "NaN" is invalid for option "size" HOT 2
- Uint8Array tests fail on s390x
- Incompatibility with rn-nodeify HOT 5
- Issue in pbkdf2/lib/default-encoding.js HOT 1
- process.version is undefined in lib/default-encoding.js on electron app
- pbkdf2\lib\default-encoding.js, process.version is undefine,
- In the electronic application, when I start nodeintegration, the program appears default-encoding.js? 9f9d:10 Uncaught TypeError: Cannot read property 'split' of undefined HOT 1
- pbkdf2 failing on some development environments
- pbkdf2\lib\default-encoding.js, Unexpected token (5:36) HOT 1
- Please consider upgrading the default hash function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pbkdf2.