Comments (2)
I didn't say absorb it into Service. I said it could be functions. The std::thread
could be moved to Service
in lieu of BatchTranslator
from bergamot-translator.
The member functions have shared state (graph_, etc) at the moment, what do you recommend, pass it around as arguments? Or have one gigantic function? Can I retain the class and move launch into a function, so batchtranslator destruct with join?
The benefit you're pointing at is that I can run single-thread and multiple-thread with the same code once threads_ are controlled by Service, if I understand correctly?
from bergamot-translator.
Related Issues (20)
- Ignore elements with `translate=no` attribute HOT 1
- Upgrade emsdk to the latest tag
- Expose C API
- Compile WASM release also only for generic CPU capabilities (without SIMD). HOT 7
- If input is pure punctuation or numbers, pass it through unmodified HOT 1
- [Feature Request] Make a LibreOffice Extension HOT 3
- Remove wormhole references HOT 2
- Confusing error message from WebAssembly + JS HOT 1
- Importing bergamot for Python fails without network connection. HOT 1
- Content types? HOT 1
- Descreptions what the Bergamond AddOn do on Firefox HOT 1
- Build WASM fails, for failure to build marian-dev
- Simpler, more general Worker HOT 2
- App is hillariously difficult to use HOT 1
- Add Italian language HOT 3
- Compile to .so file and install headers HOT 4
- Add Russian language
- update url models on example.sh
- Build native fix, line 87 on CMakeList.txt HOT 1
- Python package seems broken HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bergamot-translator.