Giter Site home page Giter Site logo

Comments (2)

jerinphilip avatar jerinphilip commented on August 29, 2024

Does it make sense to abstract the datatype here (const void *data, size_t size) and reuse it for shortlist as well? I found the following in #28 (comment).

class MemoryGift {
  const char *data() const;
  size_t length() const;
  void early_free();
};

Does it make sense to bundle these for model, shortlist (seeing as to someone who'd use bytearray uses it for efficiency purposes) and unpack it at BatchTranslator (where these are loaded)? Vocabulary I'm not sure, but it's required at service as well.

from bergamot-translator.

abhi-agg avatar abhi-agg commented on August 29, 2024

@XapaJIaMnu Can we close this issue? I think #94 was the last missing PR to close this one. Right?

from bergamot-translator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.