Giter Site home page Giter Site logo

Comments (5)

abhi-agg avatar abhi-agg commented on July 25, 2024 1

@jerinphilip There is another issue in this repo #59 that you created and sounds similar to me. I am closing that one.

from bergamot-translator.

XapaJIaMnu avatar XapaJIaMnu commented on July 25, 2024

So what i'm thinking is having something like

class marian_model {
   explicit marian_model(const void * model_bytes, const size_t model_bytes_size, const void * shortlist, const size_t shortlist_size,  const void * vocab, const size_t vocab size) {
                 validate_model_integrity();
                 validate_vocab_integrity();
                 validate_shortlist_integrity();
                 }
    marian_model() = delete;
};

Maybe include the config to it as well, and do a sanity-check that all the files are correct. Or use checksums for validation..

from bergamot-translator.

kpu avatar kpu commented on July 25, 2024

I think you meant const void *

from bergamot-translator.

abhi-agg avatar abhi-agg commented on July 25, 2024
  • Write bindings for AlignedMemory class
  • Adapt bindings of TranslationModel class to use AlignedMemory for passing model and shortlist bytes
  • Modify wasm test page to:
    • Load both model and shortlist file from local machine (instead of emscripten’s emulated file system)
    • Read these files into buffer and populate AlignedMemory instances with them
    • Provide these AlignedMemory instances while constructing TranslationModel object
    • Change config string appropriately (remove model and shortlist entry from it)
  • Test whether both model and shortlist files are successfully being passed as bytes from wasm test page
  • Test from wasm test page whether it performs inference
    • Test for at least 1 direction (e.g. ES->EN)

from bergamot-translator.

abhi-agg avatar abhi-agg commented on July 25, 2024
  • Perform all tasks for passing vocabulary files as bytes as well

from bergamot-translator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.