Options covered by TranslationRequest

[browsermt]

Options covered by TranslationRequest

[motin]

@jerinphilip

1. I am on board with the ability to configure an alignment threshold on a per-request basis. Not having to traverse the alignments matrix makes the integration easier as a consumer of the API.
2. I am on board with the ability to configure which type of quality score that should be returned (as well as configuring not to return any quality scores at all for the particular request).
3. The text picked up from HTML nodes can be paragraphs of text with several newlines at various points. As a consumer, I would expect these to be preserved by the API, so no need for a configuration parameter here. Stay faithful all the time. :)

[motin]

I made the slight tweak quality -> quality-scores since the flag covers quality scores and does not affect the quality of the returned translation.

[jerinphilip]

I added quality = true | false. Most of the returned stuff will be made optional according to provided parameters.

@abhi-agg I've started a page for comprehensive documentation of options at:

• https://github.com/browsermt/bergamot-translator/wiki/Options-covered-by-TranslationRequest

Guessing it's best to move into a .md in source to be picked up by doc tooling after we reach a consensus on the parameters and the documentation and it's implemented in source, until which all of us can enjoy fast and WYSIWYG editing.

[kpu]

I don't understand why we are using a weirdly typed key-value map for what should be a struct? Want to make it easy to add new keys? You can add member variables to a struct with default construction.