Giter Site home page Giter Site logo

Comments (8)

BrunoLevy avatar BrunoLevy commented on May 10, 2024

Ooops, I overlooked a couple of files, I'm fixing that...

from geogram.

BrunoLevy avatar BrunoLevy commented on May 10, 2024

Fixed in the latest commit (and double checked with a recursive grep).

from geogram.

dkogan avatar dkogan commented on May 10, 2024

Excellent. Thank you! You said you're releasing 1.8.2 in a few days, right? I'll wait until that release to look at this again.

from geogram.

BrunoLevy avatar BrunoLevy commented on May 10, 2024

Would you take a look at the current version ? If there are small changes to make, I'd rather include them in 1.8.2 (not possible to change once released). Thank you in advance.

from geogram.

dkogan avatar dkogan commented on May 10, 2024

I just looked at the current git. I see this:

dima@shorty:~/projects/geogram$ git grep -li 'If you modify this software, you should include a notice'

doc/devkit/PSM.dox
doc/devkit/design.dox
doc/devkit/license.dox
doc/devkit/mainpage.dox
doc/devkit/programmer.dox

from geogram.

dkogan avatar dkogan commented on May 10, 2024

While I'm at it, here are some other licensing inconsistencies (everything found by grepping the sources for "copyright"):

  • The BSD-3clause text in the LICENSE file isn't identical to the license text in most of the sources. They aren't different in any important way, but looking and finding the differences can waste people's time. Can we remove the LICENSE file? It doesn't apply to ALL the sources anyway.
  • src/lib/geogram/basic/command_line.cpp prints out a copyright statement. It doesn't have matching copyright years. Can that printing be removed?

That's it, I think. Thanks for looking at this!

from geogram.

BrunoLevy avatar BrunoLevy commented on May 10, 2024

Fixed.
Normally v1.8.2 will be created this WE, please tell me if you find something else before then.
Best,
-- B

from geogram.

BrunoLevy avatar BrunoLevy commented on May 10, 2024

1.8.2 is out !

from geogram.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.