Custom CSS does not hide warning

[brunomnsilva]

Custom CSS does not hide warning

[brunomnsilva]

Can you elaborate?

You can use the SmartGraphProperties(InputStream inputStream) constructor that accepts a file stream and pass this object to the SmartGraphPanel constructor.

Otherwise, the provided (or custom/modified) smartgraph.properties file must be in the project's root folder.

[Bertie2011]

Sorry I put you on the wrong path there... I was using the properties as an example of what does go right, to illustrate why it's odd that the CSS file warning does not get hidden after adding a stylesheet myself.

[brunomnsilva]

Hm.. so everything is okay?

[Bertie2011]

No, let me explain again. I was wrong about the location of the CSS file check, which is why the suggested solution(s) were inaccurate and confusing.

The check for the default CSS file location happens inside the constructor (SmartGraphPanel, line 180), it would be nice if we could supply our own style sheet location. I'll update the original issue description as the suggested solution was inaccurate.

[brunomnsilva]

Previously:
I'm just a little confused, because there are two base files: the properties file and the stylesheet file. You are mentioning both at the same time.

The provided constructors only receive properties and not styling. The smartgraph.css must be present in the filepath.

---

I see what you mean. I didn't see you were using panel.getStylesheets().add(//my own uri) directly.

Sorry for the CAPS, i was putting "----" 😄

[Bertie2011]

Oh boy.... I'm just never going to talk about properties again in here haha

---

Let's focus on CSS stylesheets. I can set custom CSS using SmartGraphPanel.getStylesheets().add(//uri)

It would be nice to set my own file path for CSS without seeing the warning about missing style sheets every time I create the SmartGraphPanel.

[brunomnsilva]

Yeah, I see the problem. Let me check for a simple solution.

[brunomnsilva]

I've committed an update. Now you have an additional constructor SmartGraphPanel(Graph<V, E> theGraph, SmartGraphProperties properties, SmartPlacementStrategy placementStrategy, URI cssFile) that you can use directly and avoid the warning! 👍

Use null in the other arguments if you wish to use default values. This is described in the javadoc.

[Bertie2011]

Awesome!
You should try referencing the issue on the commit or PR in question. (Just add #xx with the issue number). It will show up in this thread and gives a nice confirmation.

[brunomnsilva]

Thanks for the tip, I'll start using it! 😄