Rotating the phone to landscape and back makes it impossible to get out of Webview

[habi]

Rotating the phone to landscape and back makes it impossible to get out of Webview

[bryceco]

Yes, that's a bug. You can go back to landscape and dismiss it, rather than force-quitting.

[bryceco]

I've tried fixing this but I'm at a loss about what the cause is. Maybe somebody else would like to take a look at it:

GoMap/src/iOS/POI/POIAllTagsViewController.swift

Line 477 in c18ce70

let viewController = SFSafariViewController(url: url)

[habi]

You can go back to landscape and dismiss it

Thanks, I really failed to think of this solution! 🤪

[patricks]

I played around a bit with that problem, the same happens if I tap the "i" button on the main screen and rotate the wikipage screen (SFSafariViewController).

If I comment out the function override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) in the MainViewController the problem is fixed in both cases. This would be a really easy fix. But I don't know exactly why this function / animation is required. Maybe @bryceco knows more about it?

[bryceco]

Thanks for looking at this! It's really appreciated!

That function simply updates the frame of the embedded MapView (which is the view that holds the various layers used for editing, aerial, etc. That view isn't tied to it's parent with constraints (because I wrote it before iOS introduced constraints, and then plugged up problems with fixes like this 😅) so I update the frame manually there. It's possible that function isn't needed anymore but it needs some testing to make sure.

[patricks]

but it needs some testing to make sure

Thanks for the informations. Can I help you somehow with the testing? I already played around with the app with this code disabled and didn't find/see any problems.

[bryceco]

It looks like at some point I added constraints that take care of setting the frame, and I just confirmed that the frame is updating correctly without the function you mention so deleting it is fine. Send me a pull request! Thanks!

[habi]

Awesome work, thanks!