Regression: reset() on $this->storages

[bshaffer]

Regression: reset() on $this->storages

[bshaffer]

I am not sure why @F21 changed it. I must have missed it in merging an unrelated change. I apologize, I should have been closer to inspect the changes of the pull request.

[bshaffer]

Fixed as a part of 757087a

[till]

@bshaffer Thanks, very much! cc @dazz

[dazz]

Thanks

[bshaffer]

I will write a test to cover this. It was passing, so I merged. A bad habbit of mine :P

[till]

Sounds good. Thanks again! :)

[F21]

Sorry for the late reply guys!

Reason I changed that was to not force the client_credentials storage because if the oauth server is to only implement the JWT grant type, the client_credentials interface does not need to be implemented.

Hope that clears things up :)

[till]

@F21 In this case you should implement a null-storage of some kind. At least IMHO.

[F21]

@bshaffer: In that case, how about reverting 025b77a and 36b7c4c as well? Since we are forcing storages to implement client_credentials, we can use it to enforce type checking.

[bshaffer]

Those changes have been re-added.

So what needs to happen here is the addition of an OAuth2_ClientAssertionType_HttpBasic class. This class will implement OAuth2_ClientAssertionTypeInterface, and take ClientCredentialStorage in the constructor, as this storage class is required for this.

This is something I've been wanting to add since the JWT functionality was added.

@F21 - shouldn't reverting those changes have caused tests to break?

[F21]

@bshaffer: There shouldn't be any breakage because the tests use the Memory or PDO storage drivers and they both implement the ClientCredentials interface :)

[bshaffer]

That makes sense. if we create a mock of JWTStorage in the tests, however, it would fail

$storage = $this->createMock('OAuth2_Storage_JWT');

We should probably test for this. In the meantime, I'll add it to my list to create HttpBasic client assertion type.

[bshaffer]

closing in favor of #57