[TEST] thread_pool_test.cpp

[bshoshany]

[TEST] thread_pool_test.cpp

[bshoshany]

You forgot to add the -std=c++17 flag.

[brunolnetto]

Do you mean gcc -Wall -Wpedantic -Wextra -Wconversion -Weffc++ -std=c++17 thread_pool_test.cpp ? I still receive many errors...

http://codepad.org/PtgUzwfa

[bshoshany]

Sorry, I have no idea why you're getting all these errors. Did you make any changes to the code? If so, please compile the original source code from the GitHub repository and see if that works. If not, I would recommend reinstalling GCC, as some of its files may be missing or corrupted. I tested the library using GCC 9.4.0 on CentOS Linux 7.6.1810 and had no issues.

[brunolnetto]

May you instruct me on how do I rebuild it from the repository?

[bshoshany]

Just download the repository, extract it to an empty folder, and then compile the .cpp file.

[brunolnetto]

By compilation, do you mean "Run the command on post comment"

[bshoshany]

No. As I said, you need to compile with the -std=c++17 flag. The full command will be:

g++ thread_pool_test.cpp -std=c++17 -o thread_pool_test

You can add warning flags if you want to, but they are not necessary to compile the program.

EDIT: Changed gcc to g++ (see below).

[brunolnetto]

I did as you said:

1. Download the latest release zip file;
2. Unzip in some folder;
3. Open terminal and navigate to the folder;
4. Run command gcc thread_pool_test.cpp -std=c++17 -o thread_pool_test

I still receive this zillions of errors: http://codepad.org/yloo9wPh

[bshoshany]

I'm sorry, unfortunately I have no idea why you're getting these errors :( I suggest trying a newer version of GCC or a different compiler altogether (e.g. Clang). If that doesn't work either, please ask for help on StackOverflow.

[AlexanderSerov]

Hi @brunolnetto
I try to reproduce issue myself and indeed it's not compiled with suggested command. The errors supplied by you in codepad point out that it missed c++ standard library symbols which must be linked by default. Changing gcc to g++ made the trick (read about difference on stackoverflow). And one more flag to compiler required -pthread
Full command:
g++ thread_pool_test.cpp -std=c++17 -pthread -o thread_pool_test

[bshoshany]

LOL, I'm a total idiot! 😅 I didn't even notice you were using gcc instead of g++ and I even used that in my own example. Of course, gcc only compiles C code, while g++ compiles C++ code, and this library is in C++, not C. I definitely should have realized that before. Thanks @AlexanderSerov.

[brunolnetto]

We are all educated idiots. I suggest to shrink the README content and add the command provided by @AlexanderSerov on his commment.

My advice as potential user is to move a great amount of details from README information to the Wiki section. Try to summarize the essentials and easy-to-use instructions and then provide the Wiki URL to the user to decide if he wants to continue on a deep-dive of your library.