requestData is undefined with `POST` requests

[bugsnag]

requestData is undefined with `POST` requests

[kattrali]

Thanks for the report, @Grmiade. After some testing, this issue seems to be unrelated to the HTTP method but rather to the active domain changing, as is the case if the error is triggered by an unhandled promise rejection or other event emitter. (I have an example of promise rejection specifically here)

In Node v8.0.0, promises run in the domain which call them, though the implementation does not provide a way to capture that domain externally without wrapping the promise, and even then, domain.active is unset. The correct solution would be to remove the reliance on domains, though this probably will need to wait for the stabilization of async hooks or similar to handle asynchronous resource-specific data.

Looking into this further.

[Fjandin]

Would it be an idea to have some sort of fallback where you can set the requestData on the request object itself?

[bengourley]

Hey @Grmiade have you had a chance to try Node v8 yet? As @kattrali mentioned, the native promises there should behave in a slightly better way (if indeed you were using promises).

Unfortunately there's not a lot we can do here… domains are fundamentally flawed (which is why they have been deprecated) in ways such as this, but there isn't a direct replacement yet for the features that they provide. We continue to watch this space and will be doing some of our own investigation with async hooks. For the near future at least we just have to stick with the current implementation, which is better than not using domains at all!

In response to your suggestion @Fjandin… yes it is possible to set request data on the req object, however the difficulty is that in an error triggered by that req/res handler (in a future tick on the event loop) there is no reference back to req – which is why the information is attached to the current domain, which is available (except when it isn't 😞 ).

I could have misunderstood your suggestion however! If you do see a way of doing this, if you could sketch it out in a gist or something, that'd be great!

Closing this off as unfortunately I don't see anything we can do at present.