Large request post data causes Bugsnag_Client::notify() to fail

[bugsnag]

Large request post data causes Bugsnag_Client::notify() to fail

[kattrali]

Thank you for the thorough report, @philbates35.

Do you think it would be sensible to check the size of the post data just before sending the curl request.

Definitely. There are two fixes which would significantly improve usage here, the first is to add the actual payload size limit to the documentation (which I'm fixing now) and the second is to truncate the payloads to that size.

This behavior was recently implemented for other notifier libraries, notably Ruby (bugsnag/bugsnag-ruby#288, bugsnag/bugsnag-ruby#290) and Java (bugsnag/bugsnag-java#35). The general strategy is to check the payload size, trim long strings, and then if needed, truncate long arrays (which tend to be stacktraces).

The PHP implementation should do something similar to the other notifiers, as well as exposing the maximum payload size, if you or other users want to implement payload truncation in the before notify callback in a way which makes more sense for your reports.

I'll work on this after some documentation updates, unless someone beats me to it. In the meantime, a payload under 1Mb should be accepted.

[GrahamCampbell]

The limit currently stands at 512k. I have now fixed this. What we do is break up batch requests if they're too large, and as a last resort, strip out the meta data too.

[GrahamCampbell]

This fix will ship with v2.9.0.