Comments (9)
Thanks for the heads up @rp3e11 - we'll take a look at updating this to work as expected
In the meantime, updating your tsconfig.json
to have "skipLibCheck": true
in "compilerOptions"
should circumvent this error until the fix is in!
from builder.
Ok, thanks, do you have any idea how long it will take to fix it?
from builder.
@rp3e11 we happily accept PRs if you would like to send a pull request with the fix in it we will merge and push a dev version with your fix in it quickly
from builder.
Is there anywhere some documentation on contributing and setting up a dev environment?
from builder.
@rp3e11 is it an option for you to set skipLibCheck: false
in your tsconfig.json file?
This is a TypeScript issue that likely started after we added support for an Angular 8 release. The ideal fix for the TS errors that sometimes show up would be to upgrade to a new version of TS, but that could cause issues for people using older versions.
Ideally we'd add a fix for this to a future major release of the angular sdk.
from builder.
@ca136 I added the skipLibCheck flag to my dev environment to see whether it works and I could do some testing with builder to understand the potential. However, for the production environment I don't think it is a good idea, because it does not only disable the check for your package but also all others that we use. I think I will wait anyway for your next release since I am waiting for https://forum.builder.io/t/angular-integration/31/5.
In terms of the error, I think as well that it is a typescript error, but to my understanding the error means that the type ServerRequest is not defined in the http module of nodejs and looking at the API docs it is not. From the issue linked earlier it seems that it should be replaced by IncomingMessage in builder.class.ts and it should work, so the fix should be fast.
However, in order to test that it doesn't affect any other parts of your code, I was wondering whether you had test in place or how your dev system is built up, so I could test it before providing a pull request.
from builder.
It seems to be deprecated in node 9 that is used in your package.json type definitions. It probably dropped out in the meantime.
/**
* @deprecated Use IncomingMessage
*/
export class ServerRequest extends IncomingMessage {
connection: net.Socket;
}
from builder.
Oh good find @rp3e11 ! I had a bunch of other issues in our angular example repo due to being on an older version of Angular (8) and TypeScrip (3.5). It looks like Angular fixed the cli so Angular 9 will work with our existing code. I'll let you know when we publish a new version of the sdk that you can test!
from builder.
@rp3e11 this should be fixed in the latest @builder.io/angular: "1.1.4-0"
from builder.
Related Issues (20)
- {all : unset} taking higher specificity HOT 2
- Error: Cannot find module 'isolated-vm' HOT 7
- TypeError: The specifier “@builder.io/sdk-vue” was a bare specifier, but was not remapped to anything. HOT 8
- BlocksWrapper component adds unnecessary div & styling creating CSS issues
- Upgrading `@builder.io/sdk` to 2.2.1 breaks build HOT 1
- Upgrade isolated-vm version to latest version HOT 4
- `SIGSEGV` panic on Node.js 20 with `@builder.io/react` HOT 2
- Key option is not correctly forwarded in builder.getAll
- Builder SDK Vue breaks after 0.12.4 (properties of null (reading 'isCE') HOT 2
- defineProps macro in vue 3 with TS (custom components) HOT 1
- `@builder.io/sdk-react-native` fails to render due to rendering a `div` in `DynamicRenderer` HOT 7
- How to give just simple array as prop HOT 2
- `$elemMatch` operator does not work in the new SDK HOT 5
- Types broke in Vue SDK after 0.12.8 HOT 3
- Is it possible to have dynamically created pages? HOT 1
- see image preview instead cloud icon HOT 2
- `npm run dev` error caused by `@builder.io/dev-tools`: package.json invalid path HOT 1
- sdk-react gen2 useContext HOT 7
- `npm run dev` "package.json invalid path" error caused by `@builder.io/dev-tools` HOT 3
- [Builder.io]: Failed code evaluation: Cannot read properties of undefined (reading 'Isolate') HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from builder.